Update PublicSuffixStore::topPrivatelyControlledDomain() to take in a StringView#28866
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom May 22, 2024
Conversation
cdumez
added
the
WebCore Misc.
Collaborator
|
EWS run on previous version of this PR (hash 70a59a9) Details |
cdumez
force-pushed
the
274480_topPrivatelyControlledDomain_StringView
branch
from
70a59a9 to
79ff96d
Compare
Collaborator
|
EWS run on current version of this PR (hash 79ff96d) Details |
darinadler
approved these changes
May 21, 2024
cdumez
added
the
unsafe-merge-queue
… StringView https://bugs.webkit.org/show_bug.cgi?id=274480 Reviewed by Darin Adler. Update PublicSuffixStore::topPrivatelyControlledDomain() to take in a StringView instead of a String. Most call sites have a StringView and we don't ever need to construct a String if the host is already in the cache. * Source/WTF/wtf/HashMap.h: (WTF::HashMapEnsureTranslatorAdapter::hash): (WTF::HashMapEnsureTranslatorAdapter::equal): (WTF::HashMapEnsureTranslatorAdapter::translate): (WTF::TableTraitsArg>::ensure): * Source/WTF/wtf/text/StringHash.h: (WTF::ASCIICaseInsensitiveStringViewHashTranslator::translate): * Source/WTF/wtf/text/StringImpl.h: * Source/WebCore/dom/Document.cpp: (WebCore::Document::urlForBindings const): * Source/WebCore/page/Quirks.cpp: (WebCore::isYahooMail): (WebCore::Quirks::shouldHideSearchFieldResultsButton const): (WebCore::Quirks::isAmazon const): (WebCore::Quirks::isGoogleMaps const): * Source/WebCore/platform/PublicSuffixStore.cpp: (WebCore::PublicSuffixStore::topPrivatelyControlledDomain const): * Source/WebCore/platform/PublicSuffixStore.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::resetStateAfterProcessTermination): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch): (WebKit::WebProcessProxy::didExceedMemoryFootprintThreshold): * Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp: (TestWebKitAPI::TEST(WTF_HashMap, Ensure_Translator)): Canonical link: https://commits.webkit.org/279092@main
webkit-commit-queue
force-pushed
the
274480_topPrivatelyControlledDomain_StringView
branch
from
79ff96d to
3a59245
Compare
Collaborator
|
Committed 279092@main (3a59245): https://commits.webkit.org/279092@main Reviewed commits have been landed. Closing PR #28866 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3a59245
79ff96d
🧪 ios-wk2-wpt🧪 api-ios🧪 api-gtk