[MultiRep HEIC] Add support for matching style via drag and drop#29441
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 6084e60) Details |
Collaborator
|
EWS run on current version of this PR (hash 0d55fc4) Details |
whsieh
approved these changes
Jun 3, 2024
rr-codes
approved these changes
Jun 3, 2024
aprotyas
approved these changes
Jun 3, 2024
https://bugs.webkit.org/show_bug.cgi?id=275042 rdar://128092529 Reviewed by Richard Robinson, Abrar Rahman Protyasha and Wenson Hsieh. * Source/WebCore/page/DragController.cpp: (WebCore::DragController::concludeEditDrag): * Source/WebCore/platform/DragData.h: * Source/WebCore/platform/cocoa/DragDataCocoa.mm: (WebCore::DragData::shouldMatchStyleOnDrop const): Consult declared pasteboard types to decide whether to match style when dropping a multi-representation HEIC into web content. * Source/WebCore/platform/gtk/DragDataGtk.cpp: (WebCore::DragData::shouldMatchStyleOnDrop const): * Source/WebCore/platform/win/DragDataWin.cpp: (WebCore::DragData::shouldMatchStyleOnDrop const): Canonical link: https://commits.webkit.org/279666@main
0d55fc4 to
dc64dde
Compare
Collaborator
|
Committed 279666@main (dc64dde): https://commits.webkit.org/279666@main Reviewed commits have been landed. Closing PR #29441 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dc64dde
0d55fc4