Skip to content

[MultiRep HEIC] Add support for matching style via drag and drop#29441

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
pxlcoder:eng/275042
Jun 3, 2024
Merged

[MultiRep HEIC] Add support for matching style via drag and drop#29441
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
pxlcoder:eng/275042

Conversation

@pxlcoder
Copy link
Copy Markdown
Member

@pxlcoder pxlcoder commented Jun 3, 2024

dc64dde

[MultiRep HEIC] Add support for matching style via drag and drop
https://bugs.webkit.org/show_bug.cgi?id=275042
rdar://128092529

Reviewed by Richard Robinson, Abrar Rahman Protyasha and Wenson Hsieh.

* Source/WebCore/page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
* Source/WebCore/platform/DragData.h:
* Source/WebCore/platform/cocoa/DragDataCocoa.mm:
(WebCore::DragData::shouldMatchStyleOnDrop const):

Consult declared pasteboard types to decide whether to match style when dropping
a multi-representation HEIC into web content.

* Source/WebCore/platform/gtk/DragDataGtk.cpp:
(WebCore::DragData::shouldMatchStyleOnDrop const):
* Source/WebCore/platform/win/DragDataWin.cpp:
(WebCore::DragData::shouldMatchStyleOnDrop const):

Canonical link: https://commits.webkit.org/279666@main

0d55fc4

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pxlcoder pxlcoder requested a review from cdumez as a code owner June 3, 2024 04:25
@pxlcoder pxlcoder self-assigned this Jun 3, 2024
@pxlcoder pxlcoder added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 3, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 3, 2024
@pxlcoder pxlcoder removed the merging-blocked Applied to prevent a change from being merged label Jun 3, 2024
@pxlcoder pxlcoder requested a review from a team as a code owner June 3, 2024 05:31
@pxlcoder pxlcoder added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 3, 2024
https://bugs.webkit.org/show_bug.cgi?id=275042
rdar://128092529

Reviewed by Richard Robinson, Abrar Rahman Protyasha and Wenson Hsieh.

* Source/WebCore/page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
* Source/WebCore/platform/DragData.h:
* Source/WebCore/platform/cocoa/DragDataCocoa.mm:
(WebCore::DragData::shouldMatchStyleOnDrop const):

Consult declared pasteboard types to decide whether to match style when dropping
a multi-representation HEIC into web content.

* Source/WebCore/platform/gtk/DragDataGtk.cpp:
(WebCore::DragData::shouldMatchStyleOnDrop const):
* Source/WebCore/platform/win/DragDataWin.cpp:
(WebCore::DragData::shouldMatchStyleOnDrop const):

Canonical link: https://commits.webkit.org/279666@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 279666@main (dc64dde): https://commits.webkit.org/279666@main

Reviewed commits have been landed. Closing PR #29441 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dc64dde into WebKit:main Jun 3, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants