Skip to content

Conversation

@carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Jun 17, 2024

@carlosgcampos carlosgcampos requested a review from a team as a code owner June 17, 2024 09:52
@carlosgcampos carlosgcampos self-assigned this Jun 17, 2024
@carlosgcampos carlosgcampos added the WebKitGTK Bugs related to the Gtk API layer. label Jun 17, 2024
@GeorgesStavracas
Copy link
Contributor

LGTM. While reviewing this I learned about C++ Delegating Constructors but I don't think they can be used in this situation.

Copy link
Contributor

@mcatanzaro mcatanzaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I learned that delegating constructors apparently do not work the way I had assumed they did. Learning is good!

@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 18, 2024
https://bugs.webkit.org/show_bug.cgi?id=275148

Reviewed by Michael Catanzaro.

Fix the creation of MotionEvent when created with a widget and state.

* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(MotionEvent::MotionEvent):
(MotionEvent::setState):

Canonical link: https://commits.webkit.org/280110@main
@webkit-commit-queue
Copy link
Collaborator

Committed 280110@main (763d3dd): https://commits.webkit.org/280110@main

Reviewed commits have been landed. Closing PR #29892 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 763d3dd into WebKit:main Jun 18, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 18, 2024
@carlosgcampos carlosgcampos deleted the gtk3-movement-delta branch June 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants