-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WPE][GTK] IPC socket should use SOCK_CLOEXEC on Linux #30005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mcatanzaro:eng/WPEGTK-IPC-socket-should-use-SOCK_CLOEXEC-on-Linux
Jul 11, 2024
Merged
[WPE][GTK] IPC socket should use SOCK_CLOEXEC on Linux #30005
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mcatanzaro:eng/WPEGTK-IPC-socket-should-use-SOCK_CLOEXEC-on-Linux
Jul 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
EWS run on previous version of this PR (hash b84cd5f) Details |
b84cd5f to
6b16754
Compare
Collaborator
|
EWS run on current version of this PR (hash 6b16754) Details |
carlosgcampos
approved these changes
Jul 11, 2024
https://bugs.webkit.org/show_bug.cgi?id=275690 Reviewed by Carlos Garcia Campos. Instead of creating the IPC socket without CLOEXEC and then setting it afterwards if requested, instead create the socket with CLOEXEC and unset it afterwards if not requested. This closes the race window where the socket may leak into a subprocess spawned by another thread (which seems unlikely, but you never know what applications will do). In practice, this ensures the server socket will never leak to a subprocess. The client socket might still get leaked because CLOEXEC has to get unset at some point for the child process to receive the socket. * Source/WTF/wtf/UniStdExtras.h: * Source/WTF/wtf/playstation/UniStdExtrasPlayStation.cpp: (WTF::unsetCloseOnExec): * Source/WTF/wtf/unix/UniStdExtrasUnix.cpp: (WTF::unsetCloseOnExec): * Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp: (IPC::createPlatformConnection): Canonical link: https://commits.webkit.org/280858@main
6b16754 to
23af623
Compare
Collaborator
|
Committed 280858@main (23af623): https://commits.webkit.org/280858@main Reviewed commits have been landed. Closing PR #30005 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
23af623
6b16754