[JSC] Implement DeleteById and DeleteByVal handlers#30015
Merged
webkit-commit-queue merged 1 commit intoJun 20, 2024
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 17feec9) Details |
17feec9 to
765de01
Compare
https://bugs.webkit.org/show_bug.cgi?id=275705 rdar://130224209 Reviewed by Yijia Huang. This patch adds DeleteById and DeleteByVal handlers for Handler IC. The implementation is quite simple, and it is just following to what we did for PutByVal etc. We also make handler code generator function names consistent. Name them as Handler, not HandlerCodeGenerator. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheHandler::createPreCompiled): (JSC::getByIdLoadHandlerImpl): (JSC::getByIdLoadOwnPropertyHandler): (JSC::getByIdLoadPrototypePropertyHandler): (JSC::getByIdMissHandler): (JSC::putByIdReplaceHandler): (JSC::putByIdTransitionHandlerImpl): (JSC::putByIdTransitionNonAllocatingHandler): (JSC::putByIdTransitionNewlyAllocatingHandler): (JSC::putByIdTransitionReallocatingHandler): (JSC::deleteByIdDeleteHandler): (JSC::deleteByIdIgnoreHandlerImpl): (JSC::deleteByIdDeleteNonConfigurableHandler): (JSC::deleteByIdDeleteMissHandler): (JSC::getByValLoadHandlerImpl): (JSC::getByValWithStringLoadOwnPropertyHandler): (JSC::getByValWithStringLoadPrototypePropertyHandler): (JSC::getByValWithSymbolLoadOwnPropertyHandler): (JSC::getByValWithSymbolLoadPrototypePropertyHandler): (JSC::getByValMissHandlerImpl): (JSC::getByValWithStringMissHandler): (JSC::getByValWithSymbolMissHandler): (JSC::putByValReplaceHandlerImpl): (JSC::putByValWithStringReplaceHandler): (JSC::putByValWithSymbolReplaceHandler): (JSC::putByValTransitionHandlerImpl): (JSC::putByValWithStringTransitionNonAllocatingHandler): (JSC::putByValWithSymbolTransitionNonAllocatingHandler): (JSC::putByValWithStringTransitionNewlyAllocatingHandler): (JSC::putByValWithSymbolTransitionNewlyAllocatingHandler): (JSC::putByValWithStringTransitionReallocatingHandler): (JSC::putByValWithSymbolTransitionReallocatingHandler): (JSC::deleteByValDeleteHandlerImpl): (JSC::deleteByValIgnoreHandlerImpl): (JSC::deleteByValWithStringDeleteHandler): (JSC::deleteByValWithStringDeleteNonConfigurableHandler): (JSC::deleteByValWithStringDeleteMissHandler): (JSC::deleteByValWithSymbolDeleteHandler): (JSC::deleteByValWithSymbolDeleteNonConfigurableHandler): (JSC::deleteByValWithSymbolDeleteMissHandler): (JSC::InlineCacheCompiler::compileOneAccessCaseHandler): (JSC::getByIdLoadHandlerCodeGeneratorImpl): Deleted. (JSC::getByIdLoadOwnPropertyHandlerCodeGenerator): Deleted. (JSC::getByIdLoadPrototypePropertyHandlerCodeGenerator): Deleted. (JSC::getByIdMissHandlerCodeGenerator): Deleted. (JSC::putByIdReplaceHandlerCodeGenerator): Deleted. (JSC::putByIdTransitionHandlerCodeGeneratorImpl): Deleted. (JSC::putByIdTransitionNonAllocatingHandlerCodeGenerator): Deleted. (JSC::putByIdTransitionNewlyAllocatingHandlerCodeGenerator): Deleted. (JSC::putByIdTransitionReallocatingHandlerCodeGenerator): Deleted. (JSC::getByValLoadHandlerCodeGeneratorImpl): Deleted. (JSC::getByValWithStringLoadOwnPropertyHandlerCodeGenerator): Deleted. (JSC::getByValWithStringLoadPrototypePropertyHandlerCodeGenerator): Deleted. (JSC::getByValWithSymbolLoadOwnPropertyHandlerCodeGenerator): Deleted. (JSC::getByValWithSymbolLoadPrototypePropertyHandlerCodeGenerator): Deleted. (JSC::getByValMissHandlerCodeGeneratorImpl): Deleted. (JSC::getByValWithStringMissHandlerCodeGenerator): Deleted. (JSC::getByValWithSymbolMissHandlerCodeGenerator): Deleted. (JSC::putByValReplaceHandlerCodeGeneratorImpl): Deleted. (JSC::putByValWithStringReplaceHandlerCodeGenerator): Deleted. (JSC::putByValWithSymbolReplaceHandlerCodeGenerator): Deleted. (JSC::putByValTransitionHandlerCodeGeneratorImpl): Deleted. (JSC::putByValWithStringTransitionNonAllocatingHandlerCodeGenerator): Deleted. (JSC::putByValWithSymbolTransitionNonAllocatingHandlerCodeGenerator): Deleted. (JSC::putByValWithStringTransitionNewlyAllocatingHandlerCodeGenerator): Deleted. (JSC::putByValWithSymbolTransitionNewlyAllocatingHandlerCodeGenerator): Deleted. (JSC::putByValWithStringTransitionReallocatingHandlerCodeGenerator): Deleted. (JSC::putByValWithSymbolTransitionReallocatingHandlerCodeGenerator): Deleted. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: * Source/JavaScriptCore/jit/BaselineJITRegisters.h: * Source/JavaScriptCore/jit/JITThunks.h: Canonical link: https://commits.webkit.org/280223@main
765de01 to
a9771d4
Compare
Collaborator
|
Committed 280223@main (a9771d4): https://commits.webkit.org/280223@main Reviewed commits have been landed. Closing PR #30015 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a9771d4
17feec9
🧪 wpe-wk2🧪 api-ios🧪 gtk-wk2🧪 api-gtk🛠 jsc-armv7🧪 jsc-armv7-tests