Skip to content

Comments

[wpe][cross-toolchain-helper][browserperfdash] Define application groups for netdata#30085

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nikolaszimmermann:eng/wpecross-toolchain-helperbrowserperfdash-Define-application-groups-for-netdata
Jun 23, 2024
Merged

[wpe][cross-toolchain-helper][browserperfdash] Define application groups for netdata#30085
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nikolaszimmermann:eng/wpecross-toolchain-helperbrowserperfdash-Define-application-groups-for-netdata

Conversation

@nikolaszimmermann
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann commented Jun 22, 2024

d161b49

[wpe][cross-toolchain-helper][browserperfdash] Define application groups for netdata
https://bugs.webkit.org/show_bug.cgi?id=275779

Unreviewed configuration change.

Define cog / wpe application groups, so we can query netdata for
per-process-group specific metrics, instead of full system metrics.

The cog process group only measures the 'cog' process, whereas
the 'wpe' group sums up WPEWebProcess + WPENetworkProcess.

* Tools/yocto/meta-openembedded_backport-libbacktrace-and-newer-netdata-to-mickledore-branch.patch:

Canonical link: https://commits.webkit.org/280287@main

5b6af47

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac 🛠 wpe ✅ 🛠 wincairo
❌ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 wincairo-tests
❌ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 api-wpe
🧪 ios-wk2-wpt 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios 🧪 mac-wk2 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim 🧪 mac-wk2-stress 🧪 api-gtk
🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann self-assigned this Jun 22, 2024
@nikolaszimmermann nikolaszimmermann added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 22, 2024
@nikolaszimmermann nikolaszimmermann requested a review from clopez June 22, 2024 14:33
@nikolaszimmermann nikolaszimmermann force-pushed the eng/wpecross-toolchain-helperbrowserperfdash-Define-application-groups-for-netdata branch from de04a89 to 5b6af47 Compare June 23, 2024 11:36
@nikolaszimmermann nikolaszimmermann added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 23, 2024
…ups for netdata

https://bugs.webkit.org/show_bug.cgi?id=275779

Unreviewed configuration change.

Define cog / wpe application groups, so we can query netdata for
per-process-group specific metrics, instead of full system metrics.

The cog process group only measures the 'cog' process, whereas
the 'wpe' group sums up WPEWebProcess + WPENetworkProcess.

* Tools/yocto/meta-openembedded_backport-libbacktrace-and-newer-netdata-to-mickledore-branch.patch:

Canonical link: https://commits.webkit.org/280287@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/wpecross-toolchain-helperbrowserperfdash-Define-application-groups-for-netdata branch from 5b6af47 to d161b49 Compare June 23, 2024 11:38
@webkit-commit-queue
Copy link
Collaborator

Committed 280287@main (d161b49): https://commits.webkit.org/280287@main

Reviewed commits have been landed. Closing PR #30085 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d161b49 into WebKit:main Jun 23, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 23, 2024
@nikolaszimmermann nikolaszimmermann deleted the eng/wpecross-toolchain-helperbrowserperfdash-Define-application-groups-for-netdata branch June 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants