Skip to content

[WGSL] Compound assignments incorrectly (un)pack the assignee#30151

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
tadeuzagallo:eng/WGSL-Compound-assignments-incorrectly-unpack-the-assignee
Jun 26, 2024
Merged

[WGSL] Compound assignments incorrectly (un)pack the assignee#30151
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
tadeuzagallo:eng/WGSL-Compound-assignments-incorrectly-unpack-the-assignee

Conversation

@tadeuzagallo
Copy link
Copy Markdown
Member

@tadeuzagallo tadeuzagallo commented Jun 25, 2024

c49e508

[WGSL] Compound assignments incorrectly (un)pack the assignee
https://bugs.webkit.org/show_bug.cgi?id=275855
rdar://130082002

Reviewed by Mike Wyrzykowski.

The default behavior in the global rewriter is that all expressions get unpack,
any exceptions need to be handled manually, as we do for assignments. However,
the rewriter was missing an entry for compound assignments (e.g. x += y).

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visit):
* Source/WebGPU/WGSL/tests/valid/fuzz-130082002.wgsl: Added.

Canonical link: https://commits.webkit.org/280371@main

a40675c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Jun 25, 2024
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Jun 25, 2024
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2024
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Compound-assignments-incorrectly-unpack-the-assignee branch from a40675c to f8cc86d Compare June 26, 2024 13:46
https://bugs.webkit.org/show_bug.cgi?id=275855
rdar://130082002

Reviewed by Mike Wyrzykowski.

The default behavior in the global rewriter is that all expressions get unpack,
any exceptions need to be handled manually, as we do for assignments. However,
the rewriter was missing an entry for compound assignments (e.g. x += y).

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visit):
* Source/WebGPU/WGSL/tests/valid/fuzz-130082002.wgsl: Added.

Canonical link: https://commits.webkit.org/280371@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Compound-assignments-incorrectly-unpack-the-assignee branch from f8cc86d to c49e508 Compare June 26, 2024 13:47
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 280371@main (c49e508): https://commits.webkit.org/280371@main

Reviewed commits have been landed. Closing PR #30151 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c49e508 into WebKit:main Jun 26, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants