[WGSL] Compound assignments incorrectly (un)pack the assignee#30151
Merged
webkit-commit-queue merged 1 commit intoJun 26, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash a40675c) Details |
mwyrzykowski
approved these changes
Jun 25, 2024
a40675c to
f8cc86d
Compare
https://bugs.webkit.org/show_bug.cgi?id=275855 rdar://130082002 Reviewed by Mike Wyrzykowski. The default behavior in the global rewriter is that all expressions get unpack, any exceptions need to be handled manually, as we do for assignments. However, the rewriter was missing an entry for compound assignments (e.g. x += y). * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::visit): * Source/WebGPU/WGSL/tests/valid/fuzz-130082002.wgsl: Added. Canonical link: https://commits.webkit.org/280371@main
f8cc86d to
c49e508
Compare
Collaborator
|
Committed 280371@main (c49e508): https://commits.webkit.org/280371@main Reviewed commits have been landed. Closing PR #30151 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c49e508
a40675c