Skip to content

Conversation

@mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jun 27, 2024

a534893

[WebGPU] water demo does not show water effect
https://bugs.webkit.org/show_bug.cgi?id=275930
<radar://130566049>

Reviewed by Tadeu Zagallo.

Workaround apparent driver bug where clearDepth was not
ignored when loadAction was not MTLLoadActionClear.

No regresion to api,validation,render_pass CTS test.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):

Canonical link: https://commits.webkit.org/280581@main

aab71f1

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Jun 27, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Jun 27, 2024
@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Jul 2, 2024
https://bugs.webkit.org/show_bug.cgi?id=275930
<radar://130566049>

Reviewed by Tadeu Zagallo.

Workaround apparent driver bug where clearDepth was not
ignored when loadAction was not MTLLoadActionClear.

No regresion to api,validation,render_pass CTS test.

* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::beginRenderPass):

Canonical link: https://commits.webkit.org/280581@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-water-demo-does-not-show-water-effect branch from aab71f1 to a534893 Compare July 2, 2024 15:51
@webkit-commit-queue
Copy link
Collaborator

Committed 280581@main (a534893): https://commits.webkit.org/280581@main

Reviewed commits have been landed. Closing PR #30215 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a534893 into WebKit:main Jul 2, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants