Skip to content

[run-benchmark] Driver for chrome on Linux should avoid showing things like sign-in screen or default-browser-check#30240

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
clopez:bug-275959
Jun 27, 2024
Merged

[run-benchmark] Driver for chrome on Linux should avoid showing things like sign-in screen or default-browser-check#30240
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
clopez:bug-275959

Conversation

@clopez
Copy link
Copy Markdown
Contributor

@clopez clopez commented Jun 27, 2024

7e644f3

[run-benchmark] Driver for chrome on Linux should avoid showing things like sign-in screen or default-browser-check
https://bugs.webkit.org/show_bug.cgi?id=275959

Reviewed by Nikolas Zimmermann.

This passes to the Chrome program the right switches so it avoids showing
any first-run screen like the default-browser-check or the offer to sign-in
into the Google services.

It also removes the --temp-profile switch which never was a real switch of
Chrome but one of the Chromium version shipped in Debian.
This was not needed in any case because the browser is already executed with
HOME=/tmp/randomDir

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
(LinuxChromeDriver.prepare_env):
(LinuxChromeDriver.launch_url):
(LinuxChromeDriver.launch_driver):

Canonical link: https://commits.webkit.org/280431@main

46be794

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@clopez clopez requested a review from JonWBedard as a code owner June 27, 2024 18:22
@clopez clopez self-assigned this Jun 27, 2024
@clopez clopez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 27, 2024
@clopez clopez requested a review from nikolaszimmermann June 27, 2024 18:28
Copy link
Copy Markdown
Contributor

@nikolaszimmermann nikolaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, r=me.

@clopez clopez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 27, 2024
…s like sign-in screen or default-browser-check

https://bugs.webkit.org/show_bug.cgi?id=275959

Reviewed by Nikolas Zimmermann.

This passes to the Chrome program the right switches so it avoids showing
any first-run screen like the default-browser-check or the offer to sign-in
into the Google services.

It also removes the --temp-profile switch which never was a real switch of
Chrome but one of the Chromium version shipped in Debian.
This was not needed in any case because the browser is already executed with
HOME=/tmp/randomDir

* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
(LinuxChromeDriver.prepare_env):
(LinuxChromeDriver.launch_url):
(LinuxChromeDriver.launch_driver):

Canonical link: https://commits.webkit.org/280431@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 280431@main (7e644f3): https://commits.webkit.org/280431@main

Reviewed commits have been landed. Closing PR #30240 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7e644f3 into WebKit:main Jun 27, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants