[run-benchmark] Driver for chrome on Linux should avoid showing things like sign-in screen or default-browser-check#30240
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 46be794) Details |
nikolaszimmermann
approved these changes
Jun 27, 2024
Contributor
nikolaszimmermann
left a comment
There was a problem hiding this comment.
Excellent, r=me.
…s like sign-in screen or default-browser-check https://bugs.webkit.org/show_bug.cgi?id=275959 Reviewed by Nikolas Zimmermann. This passes to the Chrome program the right switches so it avoids showing any first-run screen like the default-browser-check or the offer to sign-in into the Google services. It also removes the --temp-profile switch which never was a real switch of Chrome but one of the Chromium version shipped in Debian. This was not needed in any case because the browser is already executed with HOME=/tmp/randomDir * Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: (LinuxChromeDriver.prepare_env): (LinuxChromeDriver.launch_url): (LinuxChromeDriver.launch_driver): Canonical link: https://commits.webkit.org/280431@main
46be794 to
7e644f3
Compare
Collaborator
|
Committed 280431@main (7e644f3): https://commits.webkit.org/280431@main Reviewed commits have been landed. Closing PR #30240 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7e644f3
46be794
🧪 api-ios