Skip to content

[WPE][cross-toolchain-helper] Attempt to fix chromium build on bots#30301

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
nikolaszimmermann:eng/WPEcross-toolchain-helper-Attempt-to-fix-chromium-build-on-bots
Jun 29, 2024
Merged

[WPE][cross-toolchain-helper] Attempt to fix chromium build on bots#30301
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
nikolaszimmermann:eng/WPEcross-toolchain-helper-Attempt-to-fix-chromium-build-on-bots

Conversation

@nikolaszimmermann
Copy link
Copy Markdown
Contributor

@nikolaszimmermann nikolaszimmermann commented Jun 29, 2024

0e25482

[WPE][cross-toolchain-helper] Attempt to fix chromium build on bots
https://bugs.webkit.org/show_bug.cgi?id=276030

Unreviewed build fix.

The chromium build currently fails on the bots,
because the node.js executable is unusable. Launching
it results in errors, as it doesn't pick up the correct
libicu* libraries -- attempt to workaround the problem
by setting 'use_system_icu=false'. The bots will tell
if this patch is acceptable or not.

Covered by WPE perf build bots.

* Tools/yocto/meta-openembedded_and_meta-webkit.patch:

Canonical link: https://commits.webkit.org/280496@main

6b1a6fc

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
❌ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 🧪 wincairo-tests
❌ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim 🧪 mac-wk2-stress 🧪 api-gtk
🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nikolaszimmermann nikolaszimmermann self-assigned this Jun 29, 2024
@nikolaszimmermann nikolaszimmermann added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 29, 2024
@nikolaszimmermann nikolaszimmermann added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 29, 2024
https://bugs.webkit.org/show_bug.cgi?id=276030

Unreviewed build fix.

The chromium build currently fails on the bots,
because the node.js executable is unusable. Launching
it results in errors, as it doesn't pick up the correct
libicu* libraries -- attempt to workaround the problem
by setting 'use_system_icu=false'. The bots will tell
if this patch is acceptable or not.

Covered by WPE perf build bots.

* Tools/yocto/meta-openembedded_and_meta-webkit.patch:

Canonical link: https://commits.webkit.org/280496@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WPEcross-toolchain-helper-Attempt-to-fix-chromium-build-on-bots branch from 6b1a6fc to 0e25482 Compare June 29, 2024 12:00
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 280496@main (0e25482): https://commits.webkit.org/280496@main

Reviewed commits have been landed. Closing PR #30301 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0e25482 into WebKit:main Jun 29, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 29, 2024
@nikolaszimmermann nikolaszimmermann deleted the eng/WPEcross-toolchain-helper-Attempt-to-fix-chromium-build-on-bots branch January 20, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants