Skip to content

Conversation

@carlosgcampos
Copy link
Contributor

@carlosgcampos carlosgcampos commented Jul 1, 2024

6461ef8

[WPE] Create the WebPageProxy after initializing activity state flags
https://bugs.webkit.org/show_bug.cgi?id=276062

Reviewed by Nikolas Zimmermann.

WebPageProxy queries the page client in the constructor to initialize
the activity flags. If we initialize the WKWPE::View flags before
creating the page we save an IPC message.

* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::View::View):
(WKWPE::View::createWebPage):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.h:
* Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp:
(WKWPE::ViewLegacy::ViewLegacy):
* Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp:
(WKWPE::ViewPlatform::ViewPlatform):
* Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp:
(WebKit::WebPreferences::platformInitializeStore):

Canonical link: https://commits.webkit.org/280567@main

5c3ee22

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@carlosgcampos carlosgcampos requested review from a team and zdobersek as code owners July 1, 2024 09:16
@carlosgcampos carlosgcampos self-assigned this Jul 1, 2024
@carlosgcampos carlosgcampos added the WPE WebKit WebKit WPE component label Jul 1, 2024
Copy link
Contributor

@nikolaszimmermann nikolaszimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@carlosgcampos carlosgcampos added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 2, 2024
https://bugs.webkit.org/show_bug.cgi?id=276062

Reviewed by Nikolas Zimmermann.

WebPageProxy queries the page client in the constructor to initialize
the activity flags. If we initialize the WKWPE::View flags before
creating the page we save an IPC message.

* Source/WebKit/UIProcess/API/wpe/WPEWebView.cpp:
(WKWPE::View::View):
(WKWPE::View::createWebPage):
* Source/WebKit/UIProcess/API/wpe/WPEWebView.h:
* Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp:
(WKWPE::ViewLegacy::ViewLegacy):
* Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp:
(WKWPE::ViewPlatform::ViewPlatform):
* Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp:
(WebKit::WebPreferences::platformInitializeStore):

Canonical link: https://commits.webkit.org/280567@main
@webkit-commit-queue
Copy link
Collaborator

Committed 280567@main (6461ef8): https://commits.webkit.org/280567@main

Reviewed commits have been landed. Closing PR #30332 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6461ef8 into WebKit:main Jul 2, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jul 2, 2024
@carlosgcampos carlosgcampos deleted the wpe-create-web-page branch July 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants