Skip to content

[WGSL] Offset parameter to texture functions should be a const-expression#30518

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
tadeuzagallo:eng/WGSL-Offset-parameter-to-texture-functions-should-be-a-const-expression
Jul 8, 2024
Merged

[WGSL] Offset parameter to texture functions should be a const-expression#30518
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
tadeuzagallo:eng/WGSL-Offset-parameter-to-texture-functions-should-be-a-const-expression

Conversation

@tadeuzagallo
Copy link
Copy Markdown
Member

@tadeuzagallo tadeuzagallo commented Jul 5, 2024

3b1cf88

[WGSL] Offset parameter to texture functions should be a const-expression
https://bugs.webkit.org/show_bug.cgi?id=276226
rdar://130227871

Reviewed by Mike Wyrzykowski.

According to the spec, the `offset` argument to texture functions must be a
const-expression, and the values must be between -8 and 7.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/texture-offset.wgsl: Added.

Canonical link: https://commits.webkit.org/280726@main

fd5d709

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Jul 5, 2024
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Jul 5, 2024
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Jul 8, 2024
…sion

https://bugs.webkit.org/show_bug.cgi?id=276226
rdar://130227871

Reviewed by Mike Wyrzykowski.

According to the spec, the `offset` argument to texture functions must be a
const-expression, and the values must be between -8 and 7.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/texture-offset.wgsl: Added.

Canonical link: https://commits.webkit.org/280726@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Offset-parameter-to-texture-functions-should-be-a-const-expression branch from fd5d709 to 3b1cf88 Compare July 8, 2024 12:23
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 280726@main (3b1cf88): https://commits.webkit.org/280726@main

Reviewed commits have been landed. Closing PR #30518 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3b1cf88 into WebKit:main Jul 8, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants