[COCOA] Remove usage of libwebrtc network manager in NetworkRTCMonitor#30961
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jul 22, 2024
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 23c2462) Details |
23c2462 to
f9f8fb9
Compare
Collaborator
|
EWS run on previous version of this PR (hash f9f8fb9) Details |
f9f8fb9 to
14af68a
Compare
Collaborator
|
EWS run on previous version of this PR (hash 14af68a) Details |
14af68a to
2c51342
Compare
Collaborator
|
EWS run on current version of this PR (hash 2c51342) Details |
eric-carlson
approved these changes
Jul 19, 2024
https://bugs.webkit.org/show_bug.cgi?id=276776 rdar://132001134 Reviewed by Eric Carlson. We remove usage of libwebrtc network manager from NetworkRTCMonitor. Instead we reimplement the functionality through POSIX API, following what is done in libwebrtc. This version is simpler as WebKit is only exposing interfaces that are actually in use (the default interface plus the interface that the page may use if different from the default one). A future patch should use more nw API for Cocoa platforms. Manually tested. * Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp: * Source/WebCore/PAL/pal/spi/cocoa/NetworkSPI.h: * Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.cpp: (WebKit::networkManager): (WebKit::NetworkManager::NetworkManager): (WebKit::NetworkManager::addListener): (WebKit::NetworkManager::removeListener): (WebKit::addressFromInterface): (WebKit::interfaceAdapterType): (WebKit::gatherNetworkMap): (WebKit::connectToRemoteAddress): (WebKit::getSocketLocalAddress): (WebKit::getDefaultIPAddress): (WebKit::NetworkManager::updateNetworks): (WebKit::isEqual): (WebKit::hasNetworkChanged): (WebKit::sortNetworks): (WebKit::NetworkManager::onGatheredNetworks): (WebKit::NetworkRTCMonitor::ref): (WebKit::NetworkRTCMonitor::deref): (WebKit::NetworkManagerWrapper::addListener): Deleted. (WebKit::NetworkManagerWrapper::removeListener): Deleted. (WebKit::NetworkManagerWrapper::onNetworksChanged): Deleted. * Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h: * Source/WebKit/Shared/RTCNetwork.h: Canonical link: https://commits.webkit.org/281185@main
2c51342 to
4aa16f2
Compare
Collaborator
|
Committed 281185@main (4aa16f2): https://commits.webkit.org/281185@main Reviewed commits have been landed. Closing PR #30961 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 mac
4aa16f2
2c51342