SourceBuffer will always perform a sync call to GPU process when there's a need to evict content.#31153
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Jul 25, 2024
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 7992193) Details
|
jyavenard
changed the title
jyavenard
force-pushed
the
eng/SourceBuffer-can-throw-QuotaExceededError-even-when-theres-evictable-content-
branch
from
7992193 to
b42051c
Compare
Collaborator
|
EWS run on previous version of this PR (hash b42051c) Details
|
youennf
approved these changes
Jul 24, 2024
jyavenard
force-pushed
the
eng/SourceBuffer-can-throw-QuotaExceededError-even-when-theres-evictable-content-
branch
from
b42051c to
fceda02
Compare
Collaborator
|
EWS run on previous version of this PR (hash fceda02) Details |
jyavenard
added
the
safe-merge-queue
Contributor
There was a problem hiding this comment.
The title could be more descriptive
Collaborator
|
Failed mac-wk2-stress checks. Please resolve failures and re-apply Rejecting #31153 from merge queue. |
webkit-ews-buildbot
added
merging-blocked
Collaborator
|
Safe-Merge-Queue: Build #27611. |
jyavenard
removed
the
merging-blocked
jyavenard
force-pushed
the
eng/SourceBuffer-can-throw-QuotaExceededError-even-when-theres-evictable-content-
branch
from
fceda02 to
a23f2e4
Compare
Collaborator
|
EWS run on current version of this PR (hash a23f2e4) Details |
…e's a need to evict content. https://bugs.webkit.org/show_bug.cgi?id=276999 rdar://132402500 Reviewed by Youenn Fablet. Prior 275380@main, eviction was performed synchronously and the eviction data algorithm would evict 3s of data at a time until there was sufficient buffer space available for the appendBuffer operation to complete. In 275380@main, we pre-calculated how much data could be removed in total. However, the calculation incorrectly looked at the initial 3s of removable data only. Which would make the SourceBuffer always consider that no data was evictable preventing an asynchronous eviction to occur and instead generating a sync call to SourceBufferPrivate::evictData. Added tests. * LayoutTests/media/media-source/media-managedmse-seek-and-evictable-expected.txt: Added. * LayoutTests/media/media-source/media-managedmse-seek-and-evictable.html: Added. * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: (WebCore::SourceBuffer::evictableSize const): * Source/WebCore/Modules/mediasource/SourceBuffer.h: * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::seekToTime): (WebCore::SourceBufferPrivate::computeEvictionData): * Source/WebCore/testing/Internals.cpp: (WebCore::Internals::evictableSize): * Source/WebCore/testing/Internals.h: * Source/WebCore/testing/Internals.idl: Canonical link: https://commits.webkit.org/281326@main
webkit-commit-queue
force-pushed
the
eng/SourceBuffer-can-throw-QuotaExceededError-even-when-theres-evictable-content-
branch
from
a23f2e4 to
082067e
Compare
Collaborator
|
Committed 281326@main (082067e): https://commits.webkit.org/281326@main Reviewed commits have been landed. Closing PR #31153 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
jyavenard
deleted the
eng/SourceBuffer-can-throw-QuotaExceededError-even-when-theres-evictable-content-
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
082067e
a23f2e4
🧪 wpe-wk2🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🛠 watch-sim