Skip to content

[WebGPU] Prevent discard_fragment from being optimized incorrectly#31232

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mwyrzykowski:eng/WebGPU-Prevent-discard_fragment-from-being-optimized-incorrectly
Jul 25, 2024
Merged

[WebGPU] Prevent discard_fragment from being optimized incorrectly#31232
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
mwyrzykowski:eng/WebGPU-Prevent-discard_fragment-from-being-optimized-incorrectly

Conversation

@mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Jul 25, 2024

1ff2845

[WebGPU] Prevent discard_fragment from being optimized incorrectly
https://bugs.webkit.org/show_bug.cgi?id=277084
rdar://131948643

Reviewed by Tadeu Zagallo.

Presumably the IR is correct since iOS and Apple Silicon Macs have
correct behavior.

Workaround is only needed on Intel and AMD chips.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/281372@main

f496d08

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Jul 25, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Jul 25, 2024
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-Prevent-discard_fragment-from-being-optimized-incorrectly branch from 4025760 to f496d08 Compare July 25, 2024 17:51
@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2024
https://bugs.webkit.org/show_bug.cgi?id=277084
rdar://131948643

Reviewed by Tadeu Zagallo.

Presumably the IR is correct since iOS and Apple Silicon Macs have
correct behavior.

Workaround is only needed on Intel and AMD chips.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/281372@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Prevent-discard_fragment-from-being-optimized-incorrectly branch from f496d08 to 1ff2845 Compare July 25, 2024 22:50
@webkit-commit-queue
Copy link
Collaborator

Committed 281372@main (1ff2845): https://commits.webkit.org/281372@main

Reviewed commits have been landed. Closing PR #31232 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1ff2845 into WebKit:main Jul 25, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants