REGRESSION (276531@main): State dropdown is invisible, unable to send feedback via Bunnings.com.au #31429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on previous version of this PR (hash ca3f51a) Details
|
heycam
approved these changes
Jul 30, 2024
Contributor
heycam
left a comment
heycam
left a comment
There was a problem hiding this comment.
r=me with comments addressed.
...s/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative.html
Outdated
Show resolved
Hide resolved
Member
Author
There was a problem hiding this comment.
Same, it's name to reset the state of the test so they can be re-ran if needed when opened manually
...rm-tests/css/css-animations/display-none-to-display-block-dont-cancel.tentative-expected.txt
Outdated
Show resolved
Hide resolved
nt1m
force-pushed
the
eng/REGRESSION-276531main-State-dropdown-is-invisible-unable-to-send-feedback-via-Bunnings-com-au
branch
from
ca3f51a to
90e3b37
Compare
Collaborator
|
EWS run on previous version of this PR (hash 90e3b37) Details
|
nt1m
force-pushed
the
eng/REGRESSION-276531main-State-dropdown-is-invisible-unable-to-send-feedback-via-Bunnings-com-au
branch
from
90e3b37 to
2229a7b
Compare
Collaborator
|
EWS run on current version of this PR (hash 2229a7b) Details |
… feedback via Bunnings.com.au https://bugs.webkit.org/show_bug.cgi?id=277303 rdar://130520487 Reviewed by Cameron McCormack. We should not be cancelling animations in the case where we're starting in a hidden subtree, then animating with a keyframe that changes the display value away from none. Make sure we notify about the newly created keyframe instead. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-dont-cancel.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-dont-cancel.tentative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-dont-cancel.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block-expected.xht: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-animations/display-none-to-display-block.html: Added. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::createAnimatedElementUpdate): Canonical link: https://commits.webkit.org/281544@main
webkit-commit-queue
force-pushed
the
eng/REGRESSION-276531main-State-dropdown-is-invisible-unable-to-send-feedback-via-Bunnings-com-au
branch
from
2229a7b to
72ac253
Compare
Collaborator
|
Committed 281544@main (72ac253): https://commits.webkit.org/281544@main Reviewed commits have been landed. Closing PR #31429 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
nt1m
deleted the
eng/REGRESSION-276531main-State-dropdown-is-invisible-unable-to-send-feedback-via-Bunnings-com-au
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
72ac253
2229a7b
🧪 wpe-wk2🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv🛠 tv-sim🛠 watch🛠 watch-sim