Tidy up render tree dumping#31955
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 9, 2024
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash f68b7fe) Details |
alanbaradlay
approved these changes
Aug 9, 2024
Contributor
|
Aww, I thought this was going to resolve one of my favorite FIXMEs: |
Contributor
That's RenderTreeAsText :( |
https://bugs.webkit.org/show_bug.cgi?id=277867 rdar://133554228 Reviewed by Alan Baradlay. Make the inline tree output line up, and prefix with spaces instead of dashes, since there's no state to be printed for these lines. * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: (WebCore::LayoutIntegration::showInlineContent): Canonical link: https://commits.webkit.org/282063@main
f68b7fe to
dc97ee5
Compare
Collaborator
|
Committed 282063@main (dc97ee5): https://commits.webkit.org/282063@main Reviewed commits have been landed. Closing PR #31955 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dc97ee5
f68b7fe
🧪 mac-AS-debug-wk2