Skip to content

Tidy up render tree dumping#31955

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
smfr:eng/Tidy-up-render-tree-dumping
Aug 9, 2024
Merged

Tidy up render tree dumping#31955
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
smfr:eng/Tidy-up-render-tree-dumping

Conversation

@smfr
Copy link
Contributor

@smfr smfr commented Aug 9, 2024

@smfr smfr self-assigned this Aug 9, 2024
@smfr smfr added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Aug 9, 2024
@weinig
Copy link
Contributor

weinig commented Aug 9, 2024

Aww, I thought this was going to resolve one of my favorite FIXMEs:

ASCIILiteral RenderBlock::renderName() const
{
    if (isBody())
        return "RenderBody"_s; // FIXME: Temporary hack until we know that the regression tests pass.

@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label Aug 9, 2024
@alanbaradlay
Copy link
Contributor

Aww, I thought this was going to resolve one of my favorite FIXMEs:

ASCIILiteral RenderBlock::renderName() const
{
    if (isBody())
        return "RenderBody"_s; // FIXME: Temporary hack until we know that the regression tests pass.

That's RenderTreeAsText :(

https://bugs.webkit.org/show_bug.cgi?id=277867
rdar://133554228

Reviewed by Alan Baradlay.

Make the inline tree output line up, and prefix with spaces instead of
dashes, since there's no state to be printed for these lines.

* Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::showInlineContent):

Canonical link: https://commits.webkit.org/282063@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Tidy-up-render-tree-dumping branch from f68b7fe to dc97ee5 Compare August 9, 2024 22:33
@webkit-commit-queue
Copy link
Collaborator

Committed 282063@main (dc97ee5): https://commits.webkit.org/282063@main

Reviewed commits have been landed. Closing PR #31955 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dc97ee5 into WebKit:main Aug 9, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 9, 2024
@smfr smfr deleted the eng/Tidy-up-render-tree-dumping branch October 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants