Skip to content

Remove unused/outdated run-layout-jsc script#31969

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
kmiller68:eng/Remove-unusedoutdated-run-layout-jsc-script
Aug 16, 2024
Merged

Remove unused/outdated run-layout-jsc script#31969
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
kmiller68:eng/Remove-unusedoutdated-run-layout-jsc-script

Conversation

@kmiller68
Copy link
Copy Markdown
Contributor

@kmiller68 kmiller68 commented Aug 9, 2024

4e1810f

Remove unused/outdated run-layout-jsc script
https://bugs.webkit.org/show_bug.cgi?id=277879
rdar://133560101

Reviewed by Mark Lam.

As far as I know, no one uses this script. Let's get rid of it
since using it doesn't seem to work anyway and it just confuses
people.

If someone wants to run the JSC CLIable LayoutTests they can
just run `run-jsc-stress-tests LayoutTests/jsc-layout-tests.yaml`,
which I believe works for all ports.

* Tools/Scripts/run-layout-jsc: Removed.

Canonical link: https://commits.webkit.org/282365@main

a8eb7da

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ⏳ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@kmiller68 kmiller68 requested a review from JonWBedard as a code owner August 9, 2024 20:06
@kmiller68 kmiller68 self-assigned this Aug 9, 2024
@kmiller68 kmiller68 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Aug 9, 2024
@kmiller68 kmiller68 force-pushed the eng/Remove-unusedoutdated-run-layout-jsc-script branch from fc2203b to a8eb7da Compare August 9, 2024 20:08
Copy link
Copy Markdown

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 9, 2024
@kmiller68 kmiller68 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Aug 16, 2024
https://bugs.webkit.org/show_bug.cgi?id=277879
rdar://133560101

Reviewed by Mark Lam.

As far as I know, no one uses this script. Let's get rid of it
since using it doesn't seem to work anyway and it just confuses
people.

If someone wants to run the JSC CLIable LayoutTests they can
just run `run-jsc-stress-tests LayoutTests/jsc-layout-tests.yaml`,
which I believe works for all ports.

* Tools/Scripts/run-layout-jsc: Removed.

Canonical link: https://commits.webkit.org/282365@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-unusedoutdated-run-layout-jsc-script branch from a8eb7da to 4e1810f Compare August 16, 2024 20:21
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 282365@main (4e1810f): https://commits.webkit.org/282365@main

Reviewed commits have been landed. Closing PR #31969 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4e1810f into WebKit:main Aug 16, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 16, 2024
@kmiller68 kmiller68 deleted the eng/Remove-unusedoutdated-run-layout-jsc-script branch October 17, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants