Web Inspector: Console: show boundThis for arrow functions#32043
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 13e08a8) Details |
kmiller68
approved these changes
Aug 20, 2024
Contributor
There was a problem hiding this comment.
I think you need an exception check here.
Collaborator
|
EWS run on current version of this PR (hash 5856d6f) Details |
https://bugs.webkit.org/show_bug.cgi?id=277960 Reviewed by Keith Miller. This will help developers debug issues with `this` similar to `Function.prototype.bind()`. Note that if `this` isn't used within the body of the arrow function, it's not captured. * Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp: (Inspector::JSInjectedScriptHost::getInternalProperties): * LayoutTests/inspector/model/remote-object-get-properties.html: * LayoutTests/inspector/model/remote-object-get-properties-expected.txt: * LayoutTests/inspector/runtime/getDisplayableProperties.html: * LayoutTests/inspector/runtime/getDisplayableProperties-expected.txt: * LayoutTests/inspector/runtime/getProperties.html: * LayoutTests/inspector/runtime/getProperties-expected.txt: Canonical link: https://commits.webkit.org/282553@main
5856d6f to
40f536f
Compare
Collaborator
|
Committed 282553@main (40f536f): https://commits.webkit.org/282553@main Reviewed commits have been landed. Closing PR #32043 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
40f536f
5856d6f