[UnifiedPDF] Use std::optional::transform() in enqueueTilePaintIfNecessary#32073
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 3cffe10) Details |
hortont424
approved these changes
Aug 12, 2024
Member
Author
|
Test failures are unrelated. Thanks for the review! |
3cffe10 to
8ec3f6d
Compare
…ssary https://bugs.webkit.org/show_bug.cgi?id=277985 rdar://133719325 Reviewed by Tim Horton. We essentially hand-write `std::optional::transform()` in 282135@main, so this patch just migrates to using the standard library version instead. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::AsyncPDFRenderer::enqueueTilePaintIfNecessary): Canonical link: https://commits.webkit.org/282154@main
8ec3f6d to
59b7185
Compare
Collaborator
|
Committed 282154@main (59b7185): https://commits.webkit.org/282154@main Reviewed commits have been landed. Closing PR #32073 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
59b7185
3cffe10
🧪 wpe-wk2🧪 gtk-wk2🛠 tv🛠 watch-sim