Skip to content

[UnifiedPDF] Use std::optional::transform() in enqueueTilePaintIfNecessary#32073

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
aprotyas:eng/277985
Aug 13, 2024
Merged

[UnifiedPDF] Use std::optional::transform() in enqueueTilePaintIfNecessary#32073
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
aprotyas:eng/277985

Conversation

@aprotyas
Copy link
Copy Markdown
Member

@aprotyas aprotyas commented Aug 12, 2024

59b7185

[UnifiedPDF] Use std::optional::transform() in enqueueTilePaintIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=277985
rdar://133719325

Reviewed by Tim Horton.

We essentially hand-write `std::optional::transform()` in 282135@main, so
this patch just migrates to using the standard library version instead.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::enqueueTilePaintIfNecessary):

Canonical link: https://commits.webkit.org/282154@main

3cffe10

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
🛠 watch-sim

@aprotyas aprotyas requested a review from cdumez as a code owner August 12, 2024 23:11
@aprotyas aprotyas self-assigned this Aug 12, 2024
@aprotyas aprotyas added the PDF For bugs in WebKit's built-in PDF support. label Aug 12, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 13, 2024
@aprotyas
Copy link
Copy Markdown
Member Author

Test failures are unrelated. Thanks for the review!

@aprotyas aprotyas added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Aug 13, 2024
…ssary

https://bugs.webkit.org/show_bug.cgi?id=277985
rdar://133719325

Reviewed by Tim Horton.

We essentially hand-write `std::optional::transform()` in 282135@main, so
this patch just migrates to using the standard library version instead.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::enqueueTilePaintIfNecessary):

Canonical link: https://commits.webkit.org/282154@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 282154@main (59b7185): https://commits.webkit.org/282154@main

Reviewed commits have been landed. Closing PR #32073 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 59b7185 into WebKit:main Aug 13, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 13, 2024
@aprotyas aprotyas deleted the eng/277985 branch August 13, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PDF For bugs in WebKit's built-in PDF support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants