[text-box] Fix serialization of text-box shorthand#32267
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 16, 2024
Merged
[text-box] Fix serialization of text-box shorthand#32267webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash ea1ffc8) Details
|
nt1m
force-pushed
the
eng/text-box-serialization
branch
from
ea1ffc8 to
1224916
Compare
Collaborator
|
EWS run on previous version of this PR (hash 1224916) Details
|
alanbaradlay
approved these changes
Aug 15, 2024
webkit-ews-buildbot
added
the
merging-blocked
nt1m
force-pushed
the
eng/text-box-serialization
branch
from
1224916 to
a093899
Compare
Collaborator
|
EWS run on previous version of this PR (hash a093899) Details
|
nt1m
added
the
safe-merge-queue
nt1m
force-pushed
the
eng/text-box-serialization
branch
from
a093899 to
8107af4
Compare
Collaborator
|
EWS run on previous version of this PR (hash 8107af4) Details |
nt1m
force-pushed
the
eng/text-box-serialization
branch
from
8107af4 to
ad220b0
Compare
Collaborator
|
EWS run on current version of this PR (hash ad220b0) Details |
nt1m
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=278184 rdar://133974557 Reviewed by Alan Baradlay. These changes are done to ensure correct serialization: - Fix the second value default in text-box-edge/line-fit-edge (text for cap/ex and identical value for the other ones) - Omit "trim-both" when text-box-edge value is non-default, since "trim-both" is the default in that case. - none + auto serialize to normal As a cleanup, also switch from CSSValueList to CSSValuePair for text-box-edge/line-fit-edge. * LayoutTests/TestExpectations: * LayoutTests/fast/text/text-box-edge-property-parsing-expected.txt: Removed. * LayoutTests/fast/text/text-box-edge-property-parsing.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-edge-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-edge-computed.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-edge-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-edge-invalid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-edge-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-edge-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-invalid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-trim-invalid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-trim-invalid.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-inline/text-box-trim/parsing/text-box-valid.html: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::valueForTextEdge): (WebCore::ComputedStyleExtractor::textBoxShorthandValue const): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle const): (WebCore::valueForTextBoxEdge): Deleted. (WebCore::valueForLineFitEdge): Deleted. * Source/WebCore/css/ShorthandSerializer.cpp: (WebCore::ShorthandSerializer::serializeTextBox const): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeTextEdge): * Source/WebCore/style/StyleBuilderConverter.h: (WebCore::Style::BuilderConverter::convertTextEdge): Canonical link: https://commits.webkit.org/282328@main
webkit-commit-queue
force-pushed
the
eng/text-box-serialization
branch
from
ad220b0 to
ad94a49
Compare
Collaborator
|
Committed 282328@main (ad94a49): https://commits.webkit.org/282328@main Reviewed commits have been landed. Closing PR #32267 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ad94a49
ad220b0
🧪 wpe-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🛠 tv-sim🛠 watch🛠 watch-sim