Crash in TimerBase::~TimerBase via DataDetection::detectContentInFrame#32328
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 17, 2024
Merged
Crash in TimerBase::~TimerBase via DataDetection::detectContentInFrame#32328webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
rniwa
added
the
WebCore Misc.
Collaborator
|
EWS run on current version of this PR (hash b5bf41f) Details |
whsieh
approved these changes
Aug 16, 2024
rniwa
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=278259 <rdar://133488287> Reviewed by Wenson Hsieh. Speculative fix. Use a WeakPtr instead of RefPtr in detectContentInFrame so that we don't attempt to destruct Document in a background thread. * Source/WebCore/editing/cocoa/DataDetection.mm: (WebCore::DataDetection::detectContentInFrame): Canonical link: https://commits.webkit.org/282380@main
webkit-commit-queue
force-pushed
the
fix278259
branch
from
b5bf41f to
c213f14
Compare
Collaborator
|
Committed 282380@main (c213f14): https://commits.webkit.org/282380@main Reviewed commits have been landed. Closing PR #32328 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c213f14
b5bf41f
🧪 wpe-wk2🧪 gtk-wk2🧪 api-gtk🛠 tv-sim