Skip to content

Forward notifications from the UI process#32431

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
pvollan:eng/Forward-notifications-from-the-UI-process
Aug 22, 2024
Merged

Forward notifications from the UI process#32431
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
pvollan:eng/Forward-notifications-from-the-UI-process

Conversation

@pvollan
Copy link
Copy Markdown
Contributor

@pvollan pvollan commented Aug 19, 2024

2ff81f0

Forward notifications from the UI process
https://bugs.webkit.org/show_bug.cgi?id=278355
rdar://132420053

Reviewed by Sihui Liu.

For notifications that are being observed in the WebContent process, we need to forward them from the UI process.
Otherwise, the WebContent process will not respond to these notifications, because we are blocking access to
notifyd in the sandbox.

* Source/WebKit/Resources/cocoa/NotificationAllowList/EmbeddedForwardedNotifications.def:

Canonical link: https://commits.webkit.org/282630@main

45a8529

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan self-assigned this Aug 19, 2024
@pvollan pvollan added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Aug 19, 2024
@pvollan pvollan requested review from bnham, cdumez and szewai August 19, 2024 22:45
Copy link
Copy Markdown
Contributor

@szewai szewai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@pvollan
Copy link
Copy Markdown
Contributor Author

pvollan commented Aug 21, 2024

rs=me

Thanks for reviewing!

@pvollan pvollan force-pushed the eng/Forward-notifications-from-the-UI-process branch from 12fcbbb to 45a8529 Compare August 21, 2024 18:55
@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=278355
rdar://132420053

Reviewed by Sihui Liu.

For notifications that are being observed in the WebContent process, we need to forward them from the UI process.
Otherwise, the WebContent process will not respond to these notifications, because we are blocking access to
notifyd in the sandbox.

* Source/WebKit/Resources/cocoa/NotificationAllowList/EmbeddedForwardedNotifications.def:

Canonical link: https://commits.webkit.org/282630@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Forward-notifications-from-the-UI-process branch from 45a8529 to 2ff81f0 Compare August 22, 2024 19:53
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 282630@main (2ff81f0): https://commits.webkit.org/282630@main

Reviewed commits have been landed. Closing PR #32431 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2ff81f0 into WebKit:main Aug 22, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Process Model Bugs related to WebKit's multi-process architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants