Assert Lockdown Mode flag has been set before queried#32441
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Aug 21, 2024
Merged
Conversation
28654e3 to
47ecfdd
Compare
Collaborator
|
EWS run on current version of this PR (hash 47ecfdd) Details |
cdumez
approved these changes
Aug 20, 2024
Contributor
Author
|
Thanks for reviewing! |
https://bugs.webkit.org/show_bug.cgi?id=278128 rdar://133884110 Reviewed by Chris Dumez. Assert that Lockdown Mode flag has been set before queried in the WebContent process. This patch also initializes the Lockdown Mode flag in WebProcess earlier by using the value from the XPC initialization message, which is sent in the XPC extra initialization data. This patch also asserts that JSC options are set before JSC::initialize() is called. Setting JSC options after this call can lead to crashes. * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h: (WebKit::XPCServiceInitializer): * Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: (WebKit::XPCServiceInitializerDelegate::getExtraInitializationData): (WebKit::setJSCOptions): * Source/WebKit/Shared/WebProcessCreationParameters.h: * Source/WebKit/Shared/WebProcessCreationParameters.serialization.in: * Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::ProcessLauncher::finishLaunchingProcess): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::initializeNewWebProcess): * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getLaunchOptions): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeProcess): (WebKit::WebProcess::initializeWebProcess): * Source/WebKit/WebProcess/WebProcess.h: (WebKit::WebProcess::isLockdownModeEnabled const): Canonical link: https://commits.webkit.org/282562@main
47ecfdd to
3357b1f
Compare
Collaborator
|
Committed 282562@main (3357b1f): https://commits.webkit.org/282562@main Reviewed commits have been landed. Closing PR #32441 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3357b1f
47ecfdd