-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[WebGPU] std::span adoption in Queue::writeTexture #32512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mwyrzykowski:eng/WebGPU-stdspan-adoption-in-QueuewriteTexture
Aug 23, 2024
Merged
[WebGPU] std::span adoption in Queue::writeTexture #32512
webkit-commit-queue
merged 1 commit into
WebKit:main
from
mwyrzykowski:eng/WebGPU-stdspan-adoption-in-QueuewriteTexture
Aug 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
|
EWS run on previous version of this PR (hash 58b19f2) |
58b19f2 to
a4c2acf
Compare
Collaborator
|
EWS run on current version of this PR (hash a4c2acf) |
djg
reviewed
Aug 21, 2024
Contributor
djg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
djg
approved these changes
Aug 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=278447 rdar://132230609 Reviewed by Dan Glastonbury. Replace memcpy call with memcpySpan as the source data is already a span and the destination is a Vector. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/282681@main
a4c2acf to
085d136
Compare
Collaborator
|
Committed 282681@main (085d136): https://commits.webkit.org/282681@main Reviewed commits have been landed. Closing PR #32512 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
085d136
a4c2acf