Skip to content

Conversation

@mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Aug 21, 2024

@mwyrzykowski mwyrzykowski self-assigned this Aug 21, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Aug 21, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 21, 2024
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Aug 21, 2024
@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-stdspan-adoption-in-QueuewriteTexture branch from 58b19f2 to a4c2acf Compare August 21, 2024 06:15
@mwyrzykowski mwyrzykowski requested a review from djg August 21, 2024 17:09
Copy link
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Aug 23, 2024
https://bugs.webkit.org/show_bug.cgi?id=278447
rdar://132230609

Reviewed by Dan Glastonbury.

Replace memcpy call with memcpySpan as the source data
is already a span and the destination is a Vector.

* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):

Canonical link: https://commits.webkit.org/282681@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-stdspan-adoption-in-QueuewriteTexture branch from a4c2acf to 085d136 Compare August 23, 2024 23:24
@webkit-commit-queue
Copy link
Collaborator

Committed 282681@main (085d136): https://commits.webkit.org/282681@main

Reviewed commits have been landed. Closing PR #32512 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 085d136 into WebKit:main Aug 23, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants