ASSERT when asking DisplayListRecorder for a platform context

[hortont424]

b052305

ASSERT when asking DisplayListRecorder for a platform context
https://bugs.webkit.org/show_bug.cgi?id=278453
rdar://134401657

Reviewed by Abrar Rahman Protyasha.

* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:
Bug 278420 would have been much quicker to debug if we asserted when illegally
asking DisplayListRecorder for a platform context. So, do so!

* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
Instead of asking for a platform context to decide whether we can have one, ask if we can have one!

Canonical link: https://commits.webkit.org/282593@main

e27f4b2

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash ed3436f)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[hortont424]

For the ScrollbarThemeMac crashes, I think ScrollbarThemeMac::paint should consult hasPlatformContext, not call platformContext directly. I'll have to look at the GTK ones deeper.

[webkit-early-warning-system]

EWS run on current version of this PR (hash e27f4b2)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[aprotyas]

@hortont424 all of the GTK failures are EWS infra issues, I think. While you're at it, do you mind s/platform/hasPlatform here too?

WebKit/Source/WebKit/WebProcess/Plugins/PluginView.cpp

Lines 545 to 547 in b215773

	if (m_transientPaintingSnapshot) {
	if (!context.platformContext()) {
	RefPtr image = m_transientPaintingSnapshot->createImage();

[webkit-commit-queue]

Committed 282593@main (b052305): https://commits.webkit.org/282593@main

Reviewed commits have been landed. Closing PR #32520 and removing active labels.

[hortont424]

@hortont424 all of the GTK failures are EWS infra issues, I think. While you're at it, do you mind s/platform/hasPlatform here too?

WebKit/Source/WebKit/WebProcess/Plugins/PluginView.cpp

Lines 545 to 547 in b215773

	if (m_transientPaintingSnapshot) {
	if (!context.platformContext()) {
	RefPtr image = m_transientPaintingSnapshot->createImage();

Not sure how I keep missing your comments until I read my mail.

Yes, seems like we have to fix this case too!!