Skip to content

Simiplify IPC type metadata#32542

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
achristensen07:eng/Simiplify-IPC-type-metadata
Aug 26, 2024
Merged

Simiplify IPC type metadata#32542
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
achristensen07:eng/Simiplify-IPC-type-metadata

Conversation

@achristensen07
Copy link
Copy Markdown
Contributor

@achristensen07 achristensen07 commented Aug 21, 2024

3d37dc5

Simiplify IPC type metadata
https://bugs.webkit.org/show_bug.cgi?id=278478
rdar://134439503

Reviewed by Dan Glastonbury.

RectEdges isn't really a container.  Make the generator a tiny bit more aware of
templates and make its use consistent and we can remove it from the list of containers.

* Source/WebKit/Scripts/generate-serializers.py:
(generate_forward_declarations):
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(IPC::ArgumentCoder<WebCore::RectEdges<bool>>::encode):
(IPC::ArgumentCoder<WebCore::RectEdges<bool>>::decode):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h:
* Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp:
(WebKit::allSerializedTypes):
* Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(SerializedTypeInfo)):

Canonical link: https://commits.webkit.org/282738@main

7aeee87

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@achristensen07 achristensen07 requested a review from cdumez as a code owner August 21, 2024 19:49
@achristensen07 achristensen07 self-assigned this Aug 21, 2024
@achristensen07 achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Aug 21, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 21, 2024
@achristensen07 achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Aug 21, 2024
@achristensen07 achristensen07 force-pushed the eng/Simiplify-IPC-type-metadata branch from 68096fc to 7aeee87 Compare August 21, 2024 21:52
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 22, 2024
Copy link
Copy Markdown
Contributor

@djg djg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@achristensen07 achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Aug 26, 2024
https://bugs.webkit.org/show_bug.cgi?id=278478
rdar://134439503

Reviewed by Dan Glastonbury.

RectEdges isn't really a container.  Make the generator a tiny bit more aware of
templates and make its use consistent and we can remove it from the list of containers.

* Source/WebKit/Scripts/generate-serializers.py:
(generate_forward_declarations):
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
(headers_for_type):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(IPC::ArgumentCoder<WebCore::RectEdges<bool>>::encode):
(IPC::ArgumentCoder<WebCore::RectEdges<bool>>::decode):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h:
* Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp:
(WebKit::allSerializedTypes):
* Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(SerializedTypeInfo)):

Canonical link: https://commits.webkit.org/282738@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Simiplify-IPC-type-metadata branch from 7aeee87 to 3d37dc5 Compare August 26, 2024 15:57
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 282738@main (3d37dc5): https://commits.webkit.org/282738@main

Reviewed commits have been landed. Closing PR #32542 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3d37dc5 into WebKit:main Aug 26, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants