Skip to content

[libpas] do not use WebKitAdditions when it is not built as a part of bmalloc#32680

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/libpas-do-not-use-WebKitAdditions-when-it-is-not-built-as-a-part-of-bmalloc
Aug 26, 2024
Merged

[libpas] do not use WebKitAdditions when it is not built as a part of bmalloc#32680
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
Constellation:eng/libpas-do-not-use-WebKitAdditions-when-it-is-not-built-as-a-part-of-bmalloc

Conversation

@Constellation
Copy link
Copy Markdown
Member

@Constellation Constellation commented Aug 25, 2024 •
edited by webkit-early-warning-system
Loading

8699cc3

[libpas] do not use WebKitAdditions when it is not built as a part of bmalloc
https://bugs.webkit.org/show_bug.cgi?id=278620
rdar://130847131

Reviewed by Yijia Huang.

1. Do not use WebKitAdditions when it is not built as a part of bmalloc, causing build failures.
2. Upgrade deployment target of testing-purpose-only-build from macOS 11.0 to 15.0.

* Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj:
* Source/bmalloc/libpas/src/libpas/pas_utils.h:

Canonical link: https://commits.webkit.org/282745@main

bade261

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ❌ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation self-assigned this Aug 25, 2024
@Constellation Constellation added the bmalloc For bugs in bmalloc label Aug 25, 2024
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 25, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 6b63589)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
❌ 🛠 watch
✅ 🛠 watch-sim

@Constellation Constellation requested a review from a team August 25, 2024 05:50
@Constellation Constellation force-pushed the eng/libpas-do-not-use-WebKitAdditions-when-it-is-not-built-as-a-part-of-bmalloc branch from 6b63589 to 2f67fa4 Compare August 25, 2024 06:11
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 25, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 2f67fa4)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 wincairo
  🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 wincairo-tests
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1   🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 🧪 jsc-arm64 ✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
  🛠 tv   🧪 jsc-armv7-tests
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@Constellation Constellation force-pushed the eng/libpas-do-not-use-WebKitAdditions-when-it-is-not-built-as-a-part-of-bmalloc branch from 2f67fa4 to bade261 Compare August 25, 2024 06:12
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 25, 2024 •
edited
Loading

EWS run on current version of this PR (hash bade261)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ❌ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

hyjorc1
hyjorc1 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@hyjorc1 hyjorc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 26, 2024
@Constellation
[libpas] do not use WebKitAdditions when it is not built as a part of…
8699cc3 
… bmalloc

https://bugs.webkit.org/show_bug.cgi?id=278620
rdar://130847131

Reviewed by Yijia Huang.

1. Do not use WebKitAdditions when it is not built as a part of bmalloc, causing build failures.
2. Upgrade deployment target of testing-purpose-only-build from macOS 11.0 to 15.0.

* Source/bmalloc/libpas/libpas.xcodeproj/project.pbxproj:
* Source/bmalloc/libpas/src/libpas/pas_utils.h:

Canonical link: https://commits.webkit.org/282745@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/libpas-do-not-use-WebKitAdditions-when-it-is-not-built-as-a-part-of-bmalloc branch from bade261 to 8699cc3 Compare August 26, 2024 16:44
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Aug 26, 2024

Committed 282745@main (8699cc3): https://commits.webkit.org/282745@main

Reviewed commits have been landed. Closing PR #32680 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8699cc3 into WebKit:main Aug 26, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 26, 2024
@Constellation Constellation deleted the eng/libpas-do-not-use-WebKitAdditions-when-it-is-not-built-as-a-part-of-bmalloc branch August 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyjorc1 hyjorc1 hyjorc1 approved these changes

Assignees

@Constellation Constellation

Labels

bmalloc For bugs in bmalloc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Constellation @webkit-early-warning-system @webkit-commit-queue @hyjorc1