[WebGPU] Remove unused member variables and member functions#33078
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Sep 4, 2024
Conversation
Collaborator
|
EWS run on previous version of this PR (hash f698df9) Details
|
webkit-ews-buildbot
added
the
merging-blocked
mwyrzykowski
removed
the
merging-blocked
mwyrzykowski
force-pushed
the
eng/WebGPU-Remove-unused-member-variables-and-member-functions
branch
from
f698df9 to
405da1a
Compare
Collaborator
|
EWS run on current version of this PR (hash 405da1a) Details |
webkit-ews-buildbot
added
the
merging-blocked
mwyrzykowski
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=279074 rdar://135208062 Reviewed by Dan Glastonbury. Audit for retain cycles revealed some unused member variables and functions, remove these. * Source/WebCore/Modules/WebGPU/GPU.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUDevice.h: * Source/WebGPU/WebGPU/RenderPassEncoder.h: * Source/WebGPU/WebGPU/RenderPassEncoder.mm: (WebGPU::m_maxDrawCount): (WebGPU::RenderPassEncoder::endPass): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteQueueProxy.h: Canonical link: https://commits.webkit.org/283127@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Remove-unused-member-variables-and-member-functions
branch
from
405da1a to
61424ee
Compare
Collaborator
|
Committed 283127@main (61424ee): https://commits.webkit.org/283127@main Reviewed commits have been landed. Closing PR #33078 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
61424ee
405da1a
🧪 mac-AS-debug-wk2🧪 api-gtk