Allow HTTPFallback for non-standard port#33258
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Sep 6, 2024
Merged
Allow HTTPFallback for non-standard port#33258webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash fad4973) Details |
achristensen07
approved these changes
Sep 6, 2024
fad4973 to
ac7bd41
Compare
Collaborator
|
EWS run on current version of this PR (hash ac7bd41) Details |
https://bugs.webkit.org/show_bug.cgi?id=279282 rdar://problem/135439726 Reviewed by Alex Christensen. Currently, we restrict allowing HTTPFallback to either the default HTTPS port (443) or a non-standard default port that is configured for the webview. This conflicts with other places in the logic where we allow optimistically upgrading regardless of whether the port is consider the "default". This patch also moves adjusting the request timeout earlier in NetworkResourceLoader::startNetworkLoad so the existing logging correctly captures the timeout value. * Source/WebCore/platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::errorRecoveryMethod const): * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::startNetworkLoad): Canonical link: https://commits.webkit.org/283283@main
ac7bd41 to
c2c4d78
Compare
Collaborator
|
Committed 283283@main (c2c4d78): https://commits.webkit.org/283283@main Reviewed commits have been landed. Closing PR #33258 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c2c4d78
ac7bd41
🧪 wpe-wk2🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🧪 mac-intel-wk2🛠 tv🛠 tv-sim