Deploy more smart pointers in WebKit.*WebGPU #33565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffreygaren
requested review from
mwyrzykowski and
tadeuzagallo
as code owners
Collaborator
|
EWS run on previous version of this PR (hash 9851392) Details |
🧪 services
cdumez
reviewed
Sep 12, 2024
Contributor
There was a problem hiding this comment.
We normally only use a protectedFoo() functions to avoid local variables, not to initialize local variables.
Ref objectHeap = m_objectHeap.get(); is just as efficient/safe and shorter.
cdumez
reviewed
Sep 12, 2024
cdumez
reviewed
Sep 12, 2024
cdumez
reviewed
Sep 12, 2024
cdumez
reviewed
Sep 12, 2024
Contributor
There was a problem hiding this comment.
We try to use smart pointers instead of auto to make it clearer when we're dealing with start pointers.
cdumez
approved these changes
Sep 12, 2024
geoffreygaren
force-pushed
the
eng/Deploy-more-smart-pointers-in-WebKit-WebGPU
branch
from
9851392 to
16bd925
Compare
Collaborator
|
EWS run on current version of this PR (hash 16bd925) Details
|
geoffreygaren
added
the
merge-queue
mwyrzykowski
approved these changes
Sep 12, 2024
https://bugs.webkit.org/show_bug.cgi?id=279609 rdar://135903757 Reviewed by Chris Dumez. As dictated by static analysis. * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp: (WebKit::RemoteAdapter::destruct): (WebKit::RemoteAdapter::requestDevice): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp: (WebKit::RemoteBindGroup::updateExternalTextures): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp: (WebKit::RemoteCommandEncoder::destruct): (WebKit::RemoteCommandEncoder::beginRenderPass): (WebKit::RemoteCommandEncoder::beginComputePass): (WebKit::RemoteCommandEncoder::copyBufferToBuffer): (WebKit::RemoteCommandEncoder::clearBuffer): (WebKit::RemoteCommandEncoder::writeTimestamp): (WebKit::RemoteCommandEncoder::resolveQuerySet): (WebKit::RemoteCommandEncoder::finish): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp: (WebKit::RemoteCompositorIntegration::connection const): (WebKit::RemoteCompositorIntegration::recreateRenderBuffers): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp: (WebKit::RemoteComputePassEncoder::setPipeline): (WebKit::RemoteComputePassEncoder::dispatchIndirect): (WebKit::RemoteComputePassEncoder::setBindGroup): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp: (WebKit::RemoteComputePipeline::getBindGroupLayout): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp: (WebKit::RemoteDevice::destruct): (WebKit::RemoteDevice::createXRBinding): (WebKit::RemoteDevice::createBuffer): (WebKit::RemoteDevice::createTexture): (WebKit::RemoteDevice::createSampler): (WebKit::RemoteDevice::importExternalTextureFromVideoFrame): (WebKit::RemoteDevice::updateExternalTexture): (WebKit::RemoteDevice::createBindGroupLayout): (WebKit::RemoteDevice::createPipelineLayout): (WebKit::RemoteDevice::createBindGroup): (WebKit::RemoteDevice::createShaderModule): (WebKit::RemoteDevice::createComputePipeline): (WebKit::RemoteDevice::createRenderPipeline): (WebKit::RemoteDevice::createComputePipelineAsync): (WebKit::RemoteDevice::createRenderPipelineAsync): (WebKit::RemoteDevice::createCommandEncoder): (WebKit::RemoteDevice::createRenderBundleEncoder): (WebKit::RemoteDevice::createQuerySet): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h: * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp: (WebKit::RemoteRenderPipeline::getBindGroupLayout): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteAdapterProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: (WebKit::WebGPU::RemoteDeviceProxy::createTexture): * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.h: * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h: Canonical link: https://commits.webkit.org/283579@main
webkit-commit-queue
force-pushed
the
eng/Deploy-more-smart-pointers-in-WebKit-WebGPU
branch
from
16bd925 to
0cc3331
Compare
Collaborator
|
Committed 283579@main (0cc3331): https://commits.webkit.org/283579@main Reviewed commits have been landed. Closing PR #33565 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0cc3331
16bd925
🛠 wincairo🧪 wpe-wk2🧪 wincairo-tests🧪 ios-wk2🧪 api-wpe🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🧪 mac-intel-wk2🛠 tv🛠 tv-sim🛠 watch