Correct GB18030-2022 encode behavior#33769
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Sep 18, 2024
Merged
Conversation
annevk
added
the
Text
Collaborator
|
EWS run on previous version of this PR (hash 7341259) Details |
Contributor
Can you add to the description why we want to do [1]? Is this about the renaming? |
Contributor
Author
|
It's the renaming and but more importantly doing it correctly, i.e., not emitting zero bytes. I guess I can call that out in the final commit message, but I'll let the bots run for now. |
achristensen07
approved these changes
Sep 17, 2024
annevk
force-pushed
the
eng/Correct-GB18030-2022-encode-behavior
branch
from
7341259 to
df5b778
Compare
Collaborator
|
EWS run on current version of this PR (hash df5b778) Details |
🛠 🧪 jsc-arm64
annevk
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=279822 Reviewed by Alex Christensen. This does two things: 1. It restores asymmetric encode as it was in 265633@main to not emit two additional leading 0x00 bytes. 2. It removes the four-byte decode table as it duplicates the information already in gb18030RangesCodePoint(). No need to store it twice. * LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder.html: * Source/WebCore/PAL/pal/text/TextCodecCJK.cpp: (PAL::gb18030AsymmetricEncode): (PAL::TextCodecCJK::gb18030Decode): (PAL::gbEncodeShared): (PAL::gb180302022Encode): Deleted. (PAL::gb180302022Decode): Deleted. Canonical link: https://commits.webkit.org/283826@main
webkit-commit-queue
force-pushed
the
eng/Correct-GB18030-2022-encode-behavior
branch
from
df5b778 to
068d177
Compare
Collaborator
|
Committed 283826@main (068d177): https://commits.webkit.org/283826@main Reviewed commits have been landed. Closing PR #33769 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 26, 2024
This CL imports the following changes in WebKit, and modified the code to the Chromium coding style. - WebKit/WebKit#33699 - WebKit/WebKit#33769 - WebKit/WebKit#33836 Additional change: - resolved TODO, which I accidentally left in the last commit. Bug: 367985624 Change-Id: Ifa4517e972ba025b3ea0bf7cfcf29e11a101c5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5890346 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1360339}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
068d177
df5b778
🧪 wpe-wk2🧪 wincairo-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 mac-wk2-stress🧪 api-gtk🧪 vision-wk2🧪 mac-intel-wk2🛠 tv🛠 tv-sim