AX: Include ignored objects in the core, platform-agnostic accessibility tree behind a new feature flag by twilco · Pull Request #33937 · WebKit/WebKit

twilco · 2024-09-19T22:10:43Z

`f5c7df8`

AX: Include ignored objects in the core, platform-agnostic accessibility tree behind a new feature flag
https://bugs.webkit.org/show_bug.cgi?id=280012
rdar://136316595

Reviewed by Chris Fleizach.

This patch adds a compile-time feature flag, ENABLE_INCLUDE_IGNORED_IN_CORE_AX_TREE, and a runtime feature flag,
IncludeIgnoredInCoreAXTree, to start including ignored objects in the "core", platform-agnostic accessibility tree.
This is necessary to support off-main-thread text marker computation, e.g. for emitting a newline when exiting the
accessibility object of an ignored `tr` element, as one of many examples.

Prior to this commit, any use of `AXCoreObject::children` implicitly assumed that the returned objects were unignored.
With this commit, that function is renamed to `unignoredChildren`, and any context which expected to only process
unignored objects now uses it. A new function, `childrenIncludingIgnored` is added, and that is used in a few places.

There were several direct usages of `m_children` that were problematic, as `m_children` now includes ignored objects
when ENABLE_INCLUDE_IGNORED_IN_CORE_AX_TREE is true. These usages are replaced with unignoredChildren(/* updateChildrenIfNeeded */ false),
achieving the same behavior in both configurations with more explicit intent.

There are many test failures left to fix in ENABLE_INCLUDE_IGNORED_IN_CORE_AX_TREE with this change (6 ITM off, 60 ITM on).
Those will be addressed in follow-up patches. We will also need to find ways to optimize `unignoredChildren`, either by
caching the result or something else, as this naive initial implementation does show up heavily in samples since the
accessibility tree now has signifcantly more objects to traverse through.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::tabChildren):
(WebCore::AXCoreObject::unignoredChildren):
(WebCore::AXCoreObject::nextInPreOrder):
(WebCore::AXCoreObject::nextSiblingIncludingIgnored const):
(WebCore::AXCoreObject::nextUnignoredSibling const):
(WebCore::AXCoreObject::nextUnignoredSiblingOrParent const):
(WebCore::AXCoreObject::contents):
(WebCore::AXCoreObject::ariaTreeItemContent):
(WebCore::AXCoreObject::selectedRadioButton):
(WebCore::AXCoreObject::selectedTabItem):
(WebCore::AXCoreObject::appendRadioButtonDescendants const):
(WebCore::AXCoreObject::parentObjectUnignored const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::AXCoreObject::childrenIncludingIgnored):
(WebCore::AXCoreObject::unignoredChildren):
(WebCore::AXCoreObject::childrenIDs):
(WebCore::Accessibility::findUnignoredChild):
(WebCore::Accessibility::enumerateUnignoredDescendants):
(WebCore::Accessibility::findChild): Deleted.
(WebCore::Accessibility::enumerateDescendants): Deleted.
* Source/WebCore/accessibility/AXImage.cpp:
(WebCore::AXImage::imageOverlayElements):
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::streamSubtree):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::modalElementHasAccessibleContent):
(WebCore::AXObjectCache::focusedImageMapUIElement):
(WebCore::AXObjectCache::handleChildrenChanged):
* Source/WebCore/accessibility/AXSearchManager.cpp:
(WebCore::appendChildrenToArray):
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::appendChildren):
(WebCore::AXTextMarker::characterRangeForLine const):
(WebCore::AXTextMarker::lineNumberForIndex const):
* Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::rowHeader):
* Source/WebCore/accessibility/AccessibilityLabel.cpp:
(WebCore::childrenContainOnlyStaticText):
(WebCore::AccessibilityLabel::containsOnlyStaticText const):
(WebCore::AccessibilityLabel::updateChildrenIfNecessary):
* Source/WebCore/accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers):
(WebCore::AccessibilityList::determineAccessibilityRole):
* Source/WebCore/accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
(WebCore::AccessibilityListBox::visibleChildren):
(WebCore::AccessibilityListBox::elementAccessibilityHitTest const):
* Source/WebCore/accessibility/AccessibilityMathMLElement.cpp:
(WebCore::AccessibilityMathMLElement::mathRadicand):
(WebCore::AccessibilityMathMLElement::mathRootIndexObject):
(WebCore::AccessibilityMathMLElement::mathNumeratorObject):
(WebCore::AccessibilityMathMLElement::mathDenominatorObject):
(WebCore::AccessibilityMathMLElement::mathUnderObject):
(WebCore::AccessibilityMathMLElement::mathOverObject):
(WebCore::AccessibilityMathMLElement::mathBaseObject):
(WebCore::AccessibilityMathMLElement::mathSubscriptObject):
(WebCore::AccessibilityMathMLElement::mathSuperscriptObject):
* Source/WebCore/accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption):
* Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::selectedChildren):
(WebCore::AccessibilityMenuListPopup::handleChildrenChanged):
(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::boundingBoxRect const):
(WebCore::AccessibilityNodeObject::visibleChildren):
(WebCore::AccessibilityNodeObject::internalLinkElement const):
(WebCore::AccessibilityNodeObject::textAsLabelFor const):
(WebCore::AccessibilityNodeObject::stringValue const):
(WebCore::accessibleNameForNode):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::insertChild):
(WebCore::AccessibilityObject::clickPoint):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::disclosedRows):
(WebCore::AccessibilityObject::supportsPressAction const):
(WebCore::AccessibilityObject::elementAccessibilityHitTest const):
(WebCore::AccessibilityObject::includeIgnoredInCoreTree const):
(WebCore::AccessibilityObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityObject::selectedListItems):
(WebCore::AccessibilityObject::parentObjectUnignored const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::parentInCoreTree const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue const):
(WebCore::AccessibilityRenderObject::documentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest const):
(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addNodeOnlyChildren):
(WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation):
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::updateChildrenRoles):
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cells):
* Source/WebCore/accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::elementRect const):
(WebCore::AccessibilityTableColumn::columnHeader):
* Source/WebCore/accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::rowHeader):
(WebCore::AccessibilityTableRow::addChildren):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElements]):
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
(accessibleElementsForObjects):
(-[WebAccessibilityObjectWrapper accessibilityIsFirstItemInSuggestion]):
(-[WebAccessibilityObjectWrapper accessibilityIsLastItemInSuggestion]):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::setProperty):
(WebCore::AXIsolatedObject::boolAttributeValue const):
(WebCore::AXIsolatedObject::relativeFrameFromChildren const):
(WebCore::AXIsolatedObject::sibling const): Deleted.
(WebCore::AXIsolatedObject::siblingOrParent const): Deleted.
(WebCore::AXIsolatedObject::parentObjectUnignored const): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::createEmptyContent):
(WebCore::AXIsolatedTree::shouldCreateNodeChange):
(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):
(WebCore::AXIsolatedTree::updateNode):
(WebCore::AXIsolatedTree::updatePropertiesForSelfAndDescendants):
(WebCore::AXIsolatedTree::updateChildren):
(WebCore::AXIsolatedTree::removeNode):
(WebCore::AXIsolatedTree::lastMarker):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
(WebCore::AXIsolatedTree::isUnconnectedNode const):
* Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm:
(WebCore::AXIsolatedObject::textMarkerRange const):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::isEmptyGroup):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(transformSpecialChildrenCases):
(children):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

Canonical link: https://commits.webkit.org/284418@main

1c5ecac

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-19T22:10:49Z

EWS run on previous version of this PR (hash 653874b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/accessibility/AXObjectCache.cpp

Source/WebCore/accessibility/AXCoreObject.cpp

Source/WebCore/accessibility/AccessibilityListBox.cpp

webkit-early-warning-system · 2024-09-24T00:10:10Z

EWS run on previous version of this PR (hash bdbb173)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
~~🧪 bindings~~	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
~~🛠 🧪 jsc~~	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
~~🛠 🧪 jsc-arm64~~	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~	~~🛠 jsc-armv7~~
	~~🛠 tv~~		~~🧪 jsc-armv7-tests~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-09-24T00:10:57Z

EWS run on previous version of this PR (hash 07fdd42)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

twilco · 2024-09-24T00:23:18Z

@fleizach: Addressed all your comments, and made a small change that fixed a ton of tests with ENABLE(INCLUDE_IGNORED_IN_CORE_AX_TREE) (in your last review, 28 failures with ITM off, 85 with ITM on — now 6 and 60 failures respectively). You can review the new parts of the PR that give this improvement by searching for onlyAddsUnignoredChildren.

webkit-early-warning-system · 2024-09-28T05:09:43Z

EWS run on current version of this PR (hash 1c5ecac)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

…ity tree behind a new feature flag https://bugs.webkit.org/show_bug.cgi?id=280012 rdar://136316595 Reviewed by Chris Fleizach. This patch adds a compile-time feature flag, ENABLE_INCLUDE_IGNORED_IN_CORE_AX_TREE, and a runtime feature flag, IncludeIgnoredInCoreAXTree, to start including ignored objects in the "core", platform-agnostic accessibility tree. This is necessary to support off-main-thread text marker computation, e.g. for emitting a newline when exiting the accessibility object of an ignored `tr` element, as one of many examples. Prior to this commit, any use of `AXCoreObject::children` implicitly assumed that the returned objects were unignored. With this commit, that function is renamed to `unignoredChildren`, and any context which expected to only process unignored objects now uses it. A new function, `childrenIncludingIgnored` is added, and that is used in a few places. There were several direct usages of `m_children` that were problematic, as `m_children` now includes ignored objects when ENABLE_INCLUDE_IGNORED_IN_CORE_AX_TREE is true. These usages are replaced with unignoredChildren(/* updateChildrenIfNeeded */ false), achieving the same behavior in both configurations with more explicit intent. There are many test failures left to fix in ENABLE_INCLUDE_IGNORED_IN_CORE_AX_TREE with this change (6 ITM off, 60 ITM on). Those will be addressed in follow-up patches. We will also need to find ways to optimize `unignoredChildren`, either by caching the result or something else, as this naive initial implementation does show up heavily in samples since the accessibility tree now has signifcantly more objects to traverse through. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WebCore/accessibility/AXCoreObject.cpp: (WebCore::AXCoreObject::tabChildren): (WebCore::AXCoreObject::unignoredChildren): (WebCore::AXCoreObject::nextInPreOrder): (WebCore::AXCoreObject::nextSiblingIncludingIgnored const): (WebCore::AXCoreObject::nextUnignoredSibling const): (WebCore::AXCoreObject::nextUnignoredSiblingOrParent const): (WebCore::AXCoreObject::contents): (WebCore::AXCoreObject::ariaTreeItemContent): (WebCore::AXCoreObject::selectedRadioButton): (WebCore::AXCoreObject::selectedTabItem): (WebCore::AXCoreObject::appendRadioButtonDescendants const): (WebCore::AXCoreObject::parentObjectUnignored const): * Source/WebCore/accessibility/AXCoreObject.h: (WebCore::AXCoreObject::childrenIncludingIgnored): (WebCore::AXCoreObject::unignoredChildren): (WebCore::AXCoreObject::childrenIDs): (WebCore::Accessibility::findUnignoredChild): (WebCore::Accessibility::enumerateUnignoredDescendants): (WebCore::Accessibility::findChild): Deleted. (WebCore::Accessibility::enumerateDescendants): Deleted. * Source/WebCore/accessibility/AXImage.cpp: (WebCore::AXImage::imageOverlayElements): * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::streamSubtree): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::focusedImageMapUIElement): (WebCore::AXObjectCache::handleChildrenChanged): * Source/WebCore/accessibility/AXSearchManager.cpp: (WebCore::appendChildrenToArray): * Source/WebCore/accessibility/AXTextMarker.cpp: (WebCore::appendChildren): (WebCore::AXTextMarker::characterRangeForLine const): (WebCore::AXTextMarker::lineNumberForIndex const): * Source/WebCore/accessibility/AccessibilityARIAGridRow.cpp: (WebCore::AccessibilityARIAGridRow::rowHeader): * Source/WebCore/accessibility/AccessibilityLabel.cpp: (WebCore::childrenContainOnlyStaticText): (WebCore::AccessibilityLabel::containsOnlyStaticText const): (WebCore::AccessibilityLabel::updateChildrenIfNecessary): * Source/WebCore/accessibility/AccessibilityList.cpp: (WebCore::AccessibilityList::childHasPseudoVisibleListItemMarkers): (WebCore::AccessibilityList::determineAccessibilityRole): * Source/WebCore/accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::setSelectedChildren): (WebCore::AccessibilityListBox::selectedChildren): (WebCore::AccessibilityListBox::visibleChildren): (WebCore::AccessibilityListBox::elementAccessibilityHitTest const): * Source/WebCore/accessibility/AccessibilityMathMLElement.cpp: (WebCore::AccessibilityMathMLElement::mathRadicand): (WebCore::AccessibilityMathMLElement::mathRootIndexObject): (WebCore::AccessibilityMathMLElement::mathNumeratorObject): (WebCore::AccessibilityMathMLElement::mathDenominatorObject): (WebCore::AccessibilityMathMLElement::mathUnderObject): (WebCore::AccessibilityMathMLElement::mathOverObject): (WebCore::AccessibilityMathMLElement::mathBaseObject): (WebCore::AccessibilityMathMLElement::mathSubscriptObject): (WebCore::AccessibilityMathMLElement::mathSuperscriptObject): * Source/WebCore/accessibility/AccessibilityMenuList.cpp: (WebCore::AccessibilityMenuList::didUpdateActiveOption): * Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::selectedChildren): (WebCore::AccessibilityMenuListPopup::handleChildrenChanged): (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption): * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::boundingBoxRect const): (WebCore::AccessibilityNodeObject::visibleChildren): (WebCore::AccessibilityNodeObject::internalLinkElement const): (WebCore::AccessibilityNodeObject::textAsLabelFor const): (WebCore::AccessibilityNodeObject::stringValue const): (WebCore::accessibleNameForNode): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::insertChild): (WebCore::AccessibilityObject::clickPoint): (WebCore::AccessibilityObject::ariaTreeRows): (WebCore::AccessibilityObject::disclosedRows): (WebCore::AccessibilityObject::supportsPressAction const): (WebCore::AccessibilityObject::elementAccessibilityHitTest const): (WebCore::AccessibilityObject::includeIgnoredInCoreTree const): (WebCore::AccessibilityObject::ariaListboxSelectedChildren): (WebCore::AccessibilityObject::selectedListItems): (WebCore::AccessibilityObject::parentObjectUnignored const): Deleted. * Source/WebCore/accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::parentInCoreTree const): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue const): (WebCore::AccessibilityRenderObject::documentLinks): (WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest const): (WebCore::AccessibilityRenderObject::updateAttachmentViewParents): (WebCore::AccessibilityRenderObject::addNodeOnlyChildren): (WebCore::AccessibilityRenderObject::updateRoleAfterChildrenCreation): * Source/WebCore/accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::updateChildrenRoles): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cells): * Source/WebCore/accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::elementRect const): (WebCore::AccessibilityTableColumn::columnHeader): * Source/WebCore/accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::rowHeader): (WebCore::AccessibilityTableRow::addChildren): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityElements]): (-[WebAccessibilityObjectWrapper accessibilityElementCount]): (-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]): (-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]): (-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]): (accessibleElementsForObjects): (-[WebAccessibilityObjectWrapper accessibilityIsFirstItemInSuggestion]): (-[WebAccessibilityObjectWrapper accessibilityIsLastItemInSuggestion]): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::AXIsolatedObject): (WebCore::AXIsolatedObject::initializeProperties): (WebCore::AXIsolatedObject::setProperty): (WebCore::AXIsolatedObject::boolAttributeValue const): (WebCore::AXIsolatedObject::relativeFrameFromChildren const): (WebCore::AXIsolatedObject::sibling const): Deleted. (WebCore::AXIsolatedObject::siblingOrParent const): Deleted. (WebCore::AXIsolatedObject::parentObjectUnignored const): Deleted. * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::createEmptyContent): (WebCore::AXIsolatedTree::shouldCreateNodeChange): (WebCore::AXIsolatedTree::collectNodeChangesForSubtree): (WebCore::AXIsolatedTree::updateNode): (WebCore::AXIsolatedTree::updatePropertiesForSelfAndDescendants): (WebCore::AXIsolatedTree::updateChildren): (WebCore::AXIsolatedTree::removeNode): (WebCore::AXIsolatedTree::lastMarker): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: (WebCore::AXIsolatedTree::isUnconnectedNode const): * Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm: (WebCore::AXIsolatedObject::textMarkerRange const): * Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm: (WebCore::isEmptyGroup): * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (transformSpecialChildrenCases): (children): (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): (-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]): (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]): (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]): Canonical link: https://commits.webkit.org/284418@main

webkit-commit-queue · 2024-09-28T16:31:18Z

Committed 284418@main (f5c7df8): https://commits.webkit.org/284418@main

Reviewed commits have been landed. Closing PR #33937 and removing active labels.

twilco self-assigned this Sep 19, 2024

twilco added the Accessibility For bugs related to accessibility. label Sep 19, 2024

hoffmanjoshua reviewed Sep 20, 2024

View reviewed changes

Source/WebCore/accessibility/AXObjectCache.cpp Outdated Show resolved Hide resolved

fleizach reviewed Sep 20, 2024

View reviewed changes

Source/WebCore/accessibility/AXCoreObject.cpp Outdated Show resolved Hide resolved

fleizach reviewed Sep 20, 2024

View reviewed changes

Source/WebCore/accessibility/AccessibilityListBox.cpp Outdated Show resolved Hide resolved

fleizach approved these changes Sep 20, 2024

View reviewed changes

twilco force-pushed the eng/AX-Include-ignored-objects-in-the-core-platform-agnostic-accessibility-tree-behind-a-new-feature-flag branch from 653874b to bdbb173 Compare September 24, 2024 00:10

twilco force-pushed the eng/AX-Include-ignored-objects-in-the-core-platform-agnostic-accessibility-tree-behind-a-new-feature-flag branch from bdbb173 to 07fdd42 Compare September 24, 2024 00:10

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 24, 2024

twilco force-pushed the eng/AX-Include-ignored-objects-in-the-core-platform-agnostic-accessibility-tree-behind-a-new-feature-flag branch from 07fdd42 to 1c5ecac Compare September 28, 2024 05:09

twilco added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Sep 28, 2024

webkit-commit-queue force-pushed the eng/AX-Include-ignored-objects-in-the-core-platform-agnostic-accessibility-tree-behind-a-new-feature-flag branch from 1c5ecac to f5c7df8 Compare September 28, 2024 16:31

webkit-commit-queue merged commit f5c7df8 into WebKit:main Sep 28, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AX: Include ignored objects in the core, platform-agnostic accessibility tree behind a new feature flag#33937

AX: Include ignored objects in the core, platform-agnostic accessibility tree behind a new feature flag#33937
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
twilco:eng/AX-Include-ignored-objects-in-the-core-platform-agnostic-accessibility-tree-behind-a-new-feature-flag

twilco commented Sep 19, 2024 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Sep 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 24, 2024 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Sep 24, 2024 •

edited

Loading

Uh oh!

twilco commented Sep 24, 2024

Uh oh!

webkit-early-warning-system commented Sep 28, 2024 •

edited

Loading

Uh oh!

webkit-commit-queue commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

twilco commented Sep 19, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

f5c7df8

Uh oh!

webkit-early-warning-system commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilco commented Sep 24, 2024

Uh oh!

webkit-early-warning-system commented Sep 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

twilco commented Sep 19, 2024 •

edited by webkit-early-warning-system

Loading

`f5c7df8`

webkit-early-warning-system commented Sep 19, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 24, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 24, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 28, 2024 •

edited

Loading