Optimize WTF::spanReinterpretCast #33954

ddkilzer · 2024-09-20T03:24:55Z

`9359aad`

Optimize WTF::spanReinterpretCast
<https://bugs.webkit.org/show_bug.cgi?id=280032>
<rdar://136330115>

Reviewed by Alex Christensen.

* Source/WTF/wtf/StdLibExtras.h:
(WTF::spanReinterpretCast):
- Fix Extent in return type when std::dynamic_extent is not used.
- Prevent change of size in bytes when passing through
  spanReinterpretCast():
  - Limit RELEASE_ASSERT() to cases where std::dynamic_extent is used,
    and one of the following criteria:
    - The source type is smaller than the destination type, or
    - The source type is not an integral multiple of the destination
      type.
  - Use static_assert() when not using std::dynamic_extent.
- Fix name of function in message for static_assert() const-ness check.

* Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp:
(TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_DynamicExtent)): Add.
(TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_DynamicExtent_ManualRuntimeErrors)): Add.
(TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_NonDynamicExtent)): Add.
(TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_NonDynamicExtent_CompileTimeErros)): Add.
- Add tests.

Canonical link: https://commits.webkit.org/284316@main

1031833

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-20T03:25:37Z

EWS run on previous version of this PR (hash 3c61a1f)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	❌ 🛠 wpe-cairo
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	❌ 🧪 api-gtk
	~~🧪 vision-wk2~~	⏳ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	~~🛠 tv~~		~~🧪 jsc-armv7-tests~~
	~~🛠 tv-sim~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-20T03:45:03Z

EWS run on previous version of this PR (hash d060871)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WTF/wtf/StdLibExtras.h

webkit-early-warning-system · 2024-09-20T18:03:22Z

EWS run on previous version of this PR (hash 98a7c56)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-20T21:12:34Z

EWS run on previous version of this PR (hash 0803c62)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp

webkit-early-warning-system · 2024-09-21T01:46:18Z

EWS run on previous version of this PR (hash 19f5ebe)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🛠 wpe-cairo~~
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-21T02:38:46Z

EWS run on previous version of this PR (hash 1f8fa0f)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	~~🛠 gtk~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	✅ 🛠 jsc-armv7
	~~🛠 tv~~		~~🧪 jsc-armv7-tests~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-21T02:50:54Z

EWS run on previous version of this PR (hash 9d9253b)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
~~🛠 🧪 jsc~~	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv		~~🧪 jsc-armv7-tests~~
	✅ 🛠 tv-sim
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-21T03:05:31Z

EWS run on previous version of this PR (hash 39a7e5f)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

achristensen07

lgtm still.

Source/WTF/wtf/StdLibExtras.h

webkit-early-warning-system · 2024-09-26T03:55:38Z

EWS run on previous version of this PR (hash 13fc31d)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	❌ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-26T16:27:20Z

EWS run on current version of this PR (hash 1031833)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv		❌ 🧪 jsc-armv7-tests
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

<https://bugs.webkit.org/show_bug.cgi?id=280032> <rdar://136330115> Reviewed by Alex Christensen. * Source/WTF/wtf/StdLibExtras.h: (WTF::spanReinterpretCast): - Fix Extent in return type when std::dynamic_extent is not used. - Prevent change of size in bytes when passing through spanReinterpretCast(): - Limit RELEASE_ASSERT() to cases where std::dynamic_extent is used, and one of the following criteria: - The source type is smaller than the destination type, or - The source type is not an integral multiple of the destination type. - Use static_assert() when not using std::dynamic_extent. - Fix name of function in message for static_assert() const-ness check. * Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp: (TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_DynamicExtent)): Add. (TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_DynamicExtent_ManualRuntimeErrors)): Add. (TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_NonDynamicExtent)): Add. (TestWebKitAPI::TEST(WTF_StdLibExtras, SpanReinterpretCast_NonDynamicExtent_CompileTimeErros)): Add. - Add tests. Canonical link: https://commits.webkit.org/284316@main

webkit-commit-queue · 2024-09-26T21:47:02Z

Committed 284316@main (9359aad): https://commits.webkit.org/284316@main

Reviewed commits have been landed. Closing PR #33954 and removing active labels.

ddkilzer self-assigned this Sep 20, 2024

ddkilzer requested review from achristensen07 and cdumez September 20, 2024 03:33

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 20, 2024

ddkilzer removed the merging-blocked Applied to prevent a change from being merged label Sep 20, 2024

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 3c61a1f to d060871 Compare September 20, 2024 03:44

achristensen07 reviewed Sep 20, 2024

View reviewed changes

Source/WTF/wtf/StdLibExtras.h Outdated Show resolved Hide resolved

achristensen07 requested changes Sep 20, 2024

View reviewed changes

Source/WTF/wtf/StdLibExtras.h Outdated Show resolved Hide resolved

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from d060871 to 98a7c56 Compare September 20, 2024 18:03

ddkilzer requested a review from achristensen07 September 20, 2024 18:29

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 98a7c56 to 0803c62 Compare September 20, 2024 21:12

achristensen07 approved these changes Sep 20, 2024

View reviewed changes

Tools/TestWebKitAPI/Tests/WTF/StdLibExtrasTests.cpp Outdated Show resolved Hide resolved

ddkilzer requested a review from geoffreygaren September 20, 2024 22:35

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 0803c62 to 19f5ebe Compare September 21, 2024 01:46

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 19f5ebe to 1f8fa0f Compare September 21, 2024 02:38

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 1f8fa0f to 9d9253b Compare September 21, 2024 02:50

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 9d9253b to 39a7e5f Compare September 21, 2024 03:05

achristensen07 approved these changes Sep 23, 2024

View reviewed changes

Source/WTF/wtf/StdLibExtras.h Outdated Show resolved Hide resolved

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 39a7e5f to 13fc31d Compare September 26, 2024 03:17

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 26, 2024

ddkilzer removed the merging-blocked Applied to prevent a change from being merged label Sep 26, 2024

ddkilzer force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 13fc31d to 1031833 Compare September 26, 2024 16:27

ddkilzer added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 26, 2024

webkit-commit-queue force-pushed the eng/Optimize-WTFspanReinterpretCast branch from 1031833 to 9359aad Compare September 26, 2024 21:46

webkit-commit-queue merged commit 9359aad into WebKit:main Sep 26, 2024

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 26, 2024

ddkilzer deleted the eng/Optimize-WTFspanReinterpretCast branch September 26, 2024 21:57

Optimize WTF::spanReinterpretCast #33954

Optimize WTF::spanReinterpretCast #33954

Uh oh!

Conversation

ddkilzer commented Sep 20, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

9359aad

Uh oh!

webkit-early-warning-system commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

achristensen07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ddkilzer commented Sep 20, 2024 •

edited by webkit-early-warning-system

Loading

`9359aad`

webkit-early-warning-system commented Sep 20, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 20, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 20, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 20, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 21, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 21, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 21, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 21, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 26, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 26, 2024 •

edited

Loading