The "Around the World" carousel is broken on https://focal-theme-carbon.myshopify.com/#3396
Closed
rniwa wants to merge 2 commits intoWebKit:mainfrom
Closed
The "Around the World" carousel is broken on https://focal-theme-carbon.myshopify.com/#3396rniwa wants to merge 2 commits intoWebKit:mainfrom
rniwa wants to merge 2 commits intoWebKit:mainfrom
Conversation
rniwa
added
Tools / Tests
https://bugs.webkit.org/show_bug.cgi?id=244023 Reviewed by NOBODY (OOPS!). Updated web platform tests for quirks mode as of 23ca5bf. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/resources/resource-files.json: * LayoutTests/imported/w3c/web-platform-tests/quirks/META.yml: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/blocks-ignore-line-height-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/blocks-ignore-line-height.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-float-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-float.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-inline-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-inline.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-positioned-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-positioned.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-ref2.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-vertical-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk-vertical.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/body-fills-html-quirk.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/classname-query-after-sibling-adoption-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/classname-query-after-sibling-adoption.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/crashtests/list-item-whole-line-quirks-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/crashtests/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/dd-dl-firefox-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/dd-dl-firefox-001-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/dd-dl-firefox-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/limited-quirks-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/limited-quirks.html: Copied from LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/no-quirks.html. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/no-quirks-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/no-quirks.html: Copied from LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/no-quirks.html. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/quirks-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/quirks.html: Copied from LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/no-quirks.html. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/support/common.js: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/support/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/hashless-hex-color/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/historical/list-item-bullet-size-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/historical/list-item-bullet-size-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/historical/list-item-bullet-size.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/historical/vertical-align-in-quirks-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/historical/vertical-align-in-quirks.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/historical/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/html-fills-viewport-quirk-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/html-fills-viewport-quirk-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/html-fills-viewport-quirk-vertical-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/html-fills-viewport-quirk-vertical.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/html-fills-viewport-quirk.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-calculation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-calculation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-in-list-item.tentative-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-in-list-item.tentative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-limited-quirks-mode-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-limited-quirks-mode.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-quirks-mode-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-quirks-mode.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-trailing-collapsable-whitespace-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-trailing-collapsable-whitespace-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/line-height-trailing-collapsable-whitespace.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/percentage-height-calculation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/percentage-height-calculation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/percentage-height-quirk-excludes-flex-grid-001-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/percentage-height-quirk-excludes-flex-grid-001.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/percentage-height-quirk-excludes-flex-grid-002-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/percentage-height-quirk-excludes-flex-grid-002.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/reference/percentage-height-quirk-excludes-flex-grid-002-ref-expected-mismatch.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/reference/percentage-height-quirk-excludes-flex-grid-002-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/reference/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/supports-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/supports.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-nowrap-minimum-width-calculation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-nowrap-minimum-width-calculation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-width-calculation-abspos-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-width-calculation-abspos.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-width-calculation-applies-to-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-width-calculation-applies-to.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/table-replaced-descendant-percentage-height-crash.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/text-decoration-doesnt-propagate-into-tables/quirks-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/text-decoration-doesnt-propagate-into-tables/quirks-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/text-decoration-doesnt-propagate-into-tables/quirks.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/text-decoration-doesnt-propagate-into-tables/standards-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/text-decoration-doesnt-propagate-into-tables/standards-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/text-decoration-doesnt-propagate-into-tables/standards.html: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/text-decoration-doesnt-propagate-into-tables/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/no-quirks.html: * LayoutTests/imported/w3c/web-platform-tests/quirks/w3c-import.log: Added. * LayoutTests/tests-options.json:
…on.myshopify.com/ https://bugs.webkit.org/show_bug.cgi?id=242224 Unreviewed iOS build fix. * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: (WebCore::RenderLayerScrollableArea::updateScrollableAreaSet):
rniwa
changed the title
rniwa
added
Safari Technology Preview
Scrolling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
96b1bf2
54f1346