[UnifiedPDF] There's a tile flicker after resizing has finished by aprotyas · Pull Request #34010 · WebKit/WebKit

aprotyas · 2024-09-20T23:39:41Z

`cbececa`

[UnifiedPDF] There's a tile flicker after resizing has finished
https://bugs.webkit.org/show_bug.cgi?id=270041
rdar://123566595

Reviewed by NOBODY (OOPS!).

WIP.

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/TileConfigurationChangeIdentifier.h: Added.
* Source/WebCore/platform/graphics/TiledBacking.h:
* Source/WebCore/platform/graphics/ca/TileController.cpp:
(WebCore::TileController::activeConfigurationChange const):
(WebCore::TileController::destroyExistingTileConfigurationChange):
(WebCore::TileController::addPendingTilesToActiveTileConfigurationChangeIfNeeded):
(WebCore::TileController::makeTileConfigurationChange):
(WebCore::TileController::didPrepareContentForTile):
(WebCore::TileController::swapPrimaryGridWithPendingTileGrid):
(WebCore::TileController::setNeedsDisplay):
(WebCore::TileController::setNeedsDisplayInRect):
(WebCore::TileController::setContentsScale):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::tileSize const):
(WebCore::TileController::rectForTile const):
(WebCore::TileController::computeTileSize):
(WebCore::TileController::didRevalidateTiles):
(WebCore::TileController::tileGridExtent const):
(WebCore::TileController::retainedTileBackingStoreMemory const):
(WebCore::TileController::tileCoverageRect const):
* Source/WebCore/platform/graphics/ca/TileController.h:
* Source/WebCore/platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::revalidateTiles):
* Source/WebCore/platform/graphics/ca/TileGrid.h:
* Source/WebCore/platform/graphics/ca/TileGridTypes.h: Added.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm:
(WebKit::AsyncPDFRenderer::willRepaintTile):
(WebKit::AsyncPDFRenderer::willRemoveTile):
(WebKit::AsyncPDFRenderer::willRepaintAllTiles):
(WebKit::AsyncPDFRenderer::tilingScaleFactorDidChange):
(WebKit::AsyncPDFRenderer::prepareContentForTile):
(WebKit::AsyncPDFRenderer::didPrepareContentForTile):
(WebKit::AsyncPDFRenderer::cancelPrepareContentForTile):
(WebKit::AsyncPDFRenderer::didCancelTileConfigurationChange):
(WebKit::AsyncPDFRenderer::paintPDFIntoBuffer):
(WebKit::AsyncPDFRenderer::transferBufferToMainThread):
(WebKit::AsyncPDFRenderer::tileConfigurationChangeCompletionHandler):
(WebKit::AsyncPDFRenderer::pdfContentScaleChanged):
(WebKit::AsyncPDFRenderer::pdfContentChangedInRect):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm:
(WebKit::PDFDiscretePresentationController::applyWheelEventDelta):
(WebKit::PDFDiscretePresentationController::updateLayersOnLayoutChange):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h:
(WebKit::PDFPresentationController::LayoutChangeInformation::scaleFactorChangedAfterInitialLayout const):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::updateLayersOnLayoutChange):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateLayerHierarchy):
(WebKit::UnifiedPDFPlugin::setScaleFactor):
(WebKit::UnifiedPDFPlugin::updateLayout):
* Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

cbececa

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-09-20T23:39:47Z

EWS run on previous version of this PR (hash a8c3b63)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	❌ 🛠 tv
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

aprotyas · 2024-09-20T23:40:37Z

Source/WebCore/platform/graphics/ca/TileController.cpp

All of this should get rolled into TileController::tileGrid()

i.e. m_asyncTileConfigurationChangeData ? *m_asyncTileConfigurationChangeData->pendingTileGrid : tileGrid();

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm

webkit-early-warning-system · 2024-09-22T23:32:23Z

EWS run on previous version of this PR (hash 9ec3d16)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	❌ 🛠 tv
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-09-23T20:52:12Z

EWS run on previous version of this PR (hash 539e1aa)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

smfr · 2024-09-23T22:45:59Z

Source/WebCore/platform/graphics/TileConfigurationChangeIdentifier.h

Does this really need its own file?

It does not, yeah, I just followed precedence set by some other identifier types. I'll probably roll this all into TileGridTypes.h eventually.

smfr · 2024-09-23T22:47:05Z

Source/WebCore/platform/graphics/TiledBacking.h

Maybe initiateTileConfigurationChange?

What is newGrid if DidCancelTileConfigurationChange is Yes?

newGrid is unnecessary data if DidCancelTileConfigurationChange::Yes. I'm rolling this together into an optional argument.

smfr · 2024-09-23T22:48:28Z

Source/WebCore/platform/graphics/TiledBacking.h

I would call this completeTileConfigurationChange or commitTileConfigurationChange. It should probably pass the identifier back, and that can be used to identify the old and new grids?

The way I've structured the flow now, we need to know the old/new grids before commitTileConfigurationChange is called (since this would be the last step that actually does the grid swap).

So I'm renaming the method, to abstract away from the tile grid swap mechanics, but I'm keeping the signature void(TileGridIdentifier, TileGridIdentifier) for now.

smfr · 2024-09-23T22:51:36Z

Source/WebCore/platform/graphics/ca/TileController.cpp

Why not DidCancelTileConfigurationChange::Yes unconditionally?

Yeah, my comment is wrong. I was thinking of unconditionally DidCancelTileConfigurationChange::Yes here.

smfr · 2024-09-23T22:53:27Z

Source/WebCore/platform/graphics/ca/TileController.cpp

I'm not convinced that we should tell the client about the new grid yet, but maybe we should before we start asking it to prepare tiles for it?

smfr · 2024-09-23T22:57:03Z

Source/WebCore/platform/graphics/ca/TileController.cpp

smfr · 2024-09-23T22:57:22Z

Source/WebCore/platform/graphics/ca/TileController.cpp

Indeed. Worth an API test.

smfr · 2024-09-23T23:00:57Z

Source/WebCore/platform/graphics/ca/TileController.cpp

Hmm, we're in an ambiguous situation now; maybe the callers need the rect in the existing grid (if we allow it to remain "live"). Another option is to explicitly specify that the old grid becomes a zombie and won't continue repainting.

smfr · 2024-09-23T23:05:20Z

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm

I would say that the client should not get a prepareContentForTile and a willRepaintTile for initial tile creation. But if prepareContentForTile was issued and then state changed, a willRepaintTile could be issued.

smfr · 2024-09-23T23:06:20Z

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm

Why isn't this kicking off PDF buffer generation?

webkit-early-warning-system · 2024-10-02T10:51:40Z

EWS run on previous version of this PR (hash 722b711)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	✅ 🛠 tv	⏳ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

mattwoodrow · 2024-10-03T23:24:02Z

Source/WebCore/platform/graphics/ca/TileController.cpp

This seems potentially problematic.

If we're pinch zooming the PDF, and new scales are arriving to the main thread continuously at a rate faster than the plugin can paint them, won't this just cancel all of the paints?

I think that'd mean you'd just have the initial tiles displayed the whole tile (stretched to the new scale), while we keep doing lots of painting work and not displaying it.

If anything else inside the plugin is changing rendering at the same time (like an animation or something), then those changes wouldn't get displayed until you stopped pinch zooming.

It seems like we should probably suppress scale changes from reaching the plugin/tilecontroller if an existing configuration change is in progress. We'd then need to wait for the commit, the following rendering update (which is where the committed new tile grid gets serialised into a RemoteLayerTreeTransaction), and then schedule yet another rendering update. At that point we can pick up the new scale, and initiate a new configuration change.

mattwoodrow · 2024-10-03T23:32:51Z

Source/WebCore/platform/graphics/ca/TileController.cpp

Am I right in saying that the GraphicsLayers for the individual tiles will be parented to the controller's GraphicsLayer from both the new and old grid simultaneously?

Is that the behaviour we want? I guess the new tiles can asynchronously change from blank to having content and cover the old tiles, and ordering hopefully means they're on top.

mattwoodrow · 2024-10-04T01:45:37Z

Source/WebCore/platform/graphics/ca/TileController.cpp

This might fall into the category of 'too annoying at this point', but could it make sense to have the old tile grid be the one that's stored in a new variable, and the 'pending' grid be the primary tileGrid?

It seems like most operations want to operate on the pending one, we just want to keep the old one around so that it doesn't remove the tiles.

webkit-early-warning-system · 2024-10-10T13:02:37Z

EWS run on previous version of this PR (hash a9b790d)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🛠 gtk
	❌ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	❌ 🛠 vision-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	❌ 🛠 tv	✅ 🛠 mac-safer-cpp
	❌ 🛠 tv-sim
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-10-10T21:28:22Z

EWS run on previous version of this PR (hash a284210)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	❌ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	⏳ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-10-10T22:55:10Z

EWS run on previous version of this PR (hash def7eea)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	❌ 🛠 wpe-cairo
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	⏳ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

https://bugs.webkit.org/show_bug.cgi?id=270041 rdar://123566595 Reviewed by NOBODY (OOPS!). WIP. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/TileConfigurationChangeIdentifier.h: Added. * Source/WebCore/platform/graphics/TiledBacking.h: * Source/WebCore/platform/graphics/ca/TileController.cpp: (WebCore::TileController::activeConfigurationChange const): (WebCore::TileController::destroyExistingTileConfigurationChange): (WebCore::TileController::addPendingTilesToActiveTileConfigurationChangeIfNeeded): (WebCore::TileController::makeTileConfigurationChange): (WebCore::TileController::didPrepareContentForTile): (WebCore::TileController::swapPrimaryGridWithPendingTileGrid): (WebCore::TileController::setNeedsDisplay): (WebCore::TileController::setNeedsDisplayInRect): (WebCore::TileController::setContentsScale): (WebCore::TileController::revalidateTiles): (WebCore::TileController::tileSize const): (WebCore::TileController::rectForTile const): (WebCore::TileController::computeTileSize): (WebCore::TileController::didRevalidateTiles): (WebCore::TileController::tileGridExtent const): (WebCore::TileController::retainedTileBackingStoreMemory const): (WebCore::TileController::tileCoverageRect const): * Source/WebCore/platform/graphics/ca/TileController.h: * Source/WebCore/platform/graphics/ca/TileGrid.cpp: (WebCore::TileGrid::revalidateTiles): * Source/WebCore/platform/graphics/ca/TileGrid.h: * Source/WebCore/platform/graphics/ca/TileGridTypes.h: Added. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/AsyncPDFRenderer.mm: (WebKit::AsyncPDFRenderer::willRepaintTile): (WebKit::AsyncPDFRenderer::willRemoveTile): (WebKit::AsyncPDFRenderer::willRepaintAllTiles): (WebKit::AsyncPDFRenderer::tilingScaleFactorDidChange): (WebKit::AsyncPDFRenderer::prepareContentForTile): (WebKit::AsyncPDFRenderer::didPrepareContentForTile): (WebKit::AsyncPDFRenderer::cancelPrepareContentForTile): (WebKit::AsyncPDFRenderer::didCancelTileConfigurationChange): (WebKit::AsyncPDFRenderer::paintPDFIntoBuffer): (WebKit::AsyncPDFRenderer::transferBufferToMainThread): (WebKit::AsyncPDFRenderer::tileConfigurationChangeCompletionHandler): (WebKit::AsyncPDFRenderer::pdfContentScaleChanged): (WebKit::AsyncPDFRenderer::pdfContentChangedInRect): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm: (WebKit::PDFDiscretePresentationController::applyWheelEventDelta): (WebKit::PDFDiscretePresentationController::updateLayersOnLayoutChange): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFPresentationController.h: (WebKit::PDFPresentationController::LayoutChangeInformation::scaleFactorChangedAfterInitialLayout const): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm: (WebKit::PDFScrollingPresentationController::updateLayersOnLayoutChange): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::updateLayerHierarchy): (WebKit::UnifiedPDFPlugin::setScaleFactor): (WebKit::UnifiedPDFPlugin::updateLayout): * Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

webkit-early-warning-system · 2024-10-10T23:39:00Z

EWS run on current version of this PR (hash cbececa)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

aprotyas · 2024-10-15T01:03:28Z

Succeeded by #35189

aprotyas self-assigned this Sep 20, 2024

aprotyas requested a review from cdumez as a code owner September 20, 2024 23:39

aprotyas added the PDF For bugs in WebKit's built-in PDF support. label Sep 20, 2024

aprotyas commented Sep 20, 2024

View reviewed changes

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Outdated Show resolved Hide resolved

aprotyas commented Sep 20, 2024

View reviewed changes

Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDiscretePresentationController.mm Outdated Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 21, 2024

aprotyas removed the merging-blocked Applied to prevent a change from being merged label Sep 22, 2024

aprotyas force-pushed the eng/270041 branch from a8c3b63 to 9ec3d16 Compare September 22, 2024 23:32

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2024

aprotyas removed the merging-blocked Applied to prevent a change from being merged label Sep 23, 2024

aprotyas force-pushed the eng/270041 branch from 9ec3d16 to 539e1aa Compare September 23, 2024 20:52

smfr reviewed Sep 23, 2024

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 23, 2024

aprotyas removed the merging-blocked Applied to prevent a change from being merged label Oct 2, 2024

aprotyas force-pushed the eng/270041 branch from 539e1aa to 722b711 Compare October 2, 2024 10:50

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 2, 2024

mattwoodrow reviewed Oct 3, 2024

View reviewed changes

mattwoodrow reviewed Oct 4, 2024

View reviewed changes

aprotyas removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

aprotyas force-pushed the eng/270041 branch from 722b711 to a9b790d Compare October 10, 2024 13:02

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

aprotyas removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

aprotyas force-pushed the eng/270041 branch from a9b790d to a284210 Compare October 10, 2024 21:27

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

aprotyas removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

aprotyas force-pushed the eng/270041 branch from a284210 to def7eea Compare October 10, 2024 22:55

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

aprotyas removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

aprotyas force-pushed the eng/270041 branch from def7eea to cbececa Compare October 10, 2024 23:38

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 11, 2024

aprotyas closed this Oct 15, 2024

aprotyas deleted the eng/270041 branch October 15, 2024 01:03

Conversation

aprotyas commented Sep 20, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aprotyas commented Oct 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aprotyas commented Sep 20, 2024 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Sep 20, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 22, 2024 •

edited

Loading

webkit-early-warning-system commented Sep 23, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 2, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 10, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 10, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 10, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 10, 2024 •

edited

Loading