Skip to content

Add experimental setting for blocking MobileGestalt in sandbox#34294

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
pvollan:eng/Add-experimental-setting-for-blocking-MobileGestalt-in-sandbox
Sep 27, 2024
Merged

Add experimental setting for blocking MobileGestalt in sandbox#34294
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
pvollan:eng/Add-experimental-setting-for-blocking-MobileGestalt-in-sandbox

Conversation

@pvollan
Copy link
Copy Markdown
Contributor

@pvollan pvollan commented Sep 26, 2024

46fb4cb

Add experimental setting for blocking MobileGestalt in sandbox
https://bugs.webkit.org/show_bug.cgi?id=280400
rdar://136745251

Reviewed by Chris Dumez.

Add experimental setting for blocking MobileGestalt in the WebContent process sandbox on iOS.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):

Canonical link: https://commits.webkit.org/284348@main

0d58efb

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ❌ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan self-assigned this Sep 26, 2024
@pvollan pvollan added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Sep 26, 2024
@pvollan pvollan requested a review from youennf September 26, 2024 11:14
@pvollan pvollan force-pushed the eng/Add-experimental-setting-for-blocking-MobileGestalt-in-sandbox branch from 34443cd to 0d58efb Compare September 27, 2024 08:30
@pvollan
Copy link
Copy Markdown
Contributor Author

pvollan commented Sep 27, 2024

Thanks for reviewing!

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 27, 2024
https://bugs.webkit.org/show_bug.cgi?id=280400
rdar://136745251

Reviewed by Chris Dumez.

Add experimental setting for blocking MobileGestalt in the WebContent process sandbox on iOS.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/Scripts/process-entitlements.sh:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_textAnimationController):

Canonical link: https://commits.webkit.org/284348@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-experimental-setting-for-blocking-MobileGestalt-in-sandbox branch from 0d58efb to 46fb4cb Compare September 27, 2024 10:37
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 284348@main (46fb4cb): https://commits.webkit.org/284348@main

Reviewed commits have been landed. Closing PR #34294 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 46fb4cb into WebKit:main Sep 27, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Process Model Bugs related to WebKit's multi-process architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants