Skip to content

[ews-build.webkit.org] Support alternative remotes #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-early-warning-system merged 0 commits into from
Apr 25, 2022
Merged

[ews-build.webkit.org] Support alternative remotes #347

webkit-early-warning-system merged 0 commits into from
Apr 25, 2022

Conversation

@JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Apr 21, 2022 •
edited by webkit-early-warning-system
Loading

c8c184f

[ews-build.webkit.org] Support alternative remotes
https://bugs.webkit.org/show_bug.cgi?id=239617
<rdar://problem/92115230 >

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits):
(GitHubEventHandlerNoEdits.extractProperties): Remove sensative fields from non-public
pull requests.
(GitHubEventHandlerNoEdits.handle_pull_request): Generalize label process sleep.
* Tools/CISupport/ews-build/steps.py:
(CheckOutPullRequest.run): Checkout with EWS credentials.
* Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/249950@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Apr 21, 2022
@JonWBedard JonWBedard requested a review from aj062 April 21, 2022 19:56
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Apr 21, 2022
@JonWBedard
Copy link
Member Author

JonWBedard commented Apr 21, 2022

https://ews-build.webkit-uat.org/#/builders/7/builds/526 is an example of this, acting on a PR from a private remote.

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 25, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit c8c184f into WebKit:main Apr 25, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Support-alternative-remotes branch from ec22d6f to c8c184f Compare April 25, 2022 15:26
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Apr 25, 2022

Committed r293327 (249950@main): https://commits.webkit.org/249950@main

Reviewed commits have been landed. Closing PR #347 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 25, 2022
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Support-alternative-remotes branch April 26, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aj062 aj062 aj062 approved these changes

Assignees

@JonWBedard JonWBedard

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JonWBedard @webkit-early-warning-system @aj062