Skip to content

Port more StorageArea identifiers to ObjectIdentifier#34710

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
cdumez:280904_StorageArea_ObjectIdentifier
Oct 4, 2024
Merged

Port more StorageArea identifiers to ObjectIdentifier#34710
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
cdumez:280904_StorageArea_ObjectIdentifier

Conversation

@cdumez
Copy link
Copy Markdown
Contributor

@cdumez cdumez commented Oct 4, 2024

1de9b8f

Port more StorageArea identifiers to ObjectIdentifier
https://bugs.webkit.org/show_bug.cgi?id=280904

Reviewed by Darin Adler.

* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::clearStorageForWebPage):
(WebKit::NetworkStorageManager::cloneSessionStorageForWebPage):
* Source/WebKit/NetworkProcess/storage/StorageAreaBase.cpp:
(WebKit::StorageAreaBase::dispatchEvents const):
* Source/WebKit/Shared/WTFArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::dispatchMessage):
* Source/WebKit/WebProcess/WebPage/WebPageInlines.h:
(WebKit::WebPage::sessionStorageNamespaceIdentifier const):
* Source/WebKit/WebProcess/WebStorage/StorageAreaImplIdentifier.h:
* Source/WebKit/WebProcess/WebStorage/StorageAreaMapIdentifier.h:
* Source/WebKit/WebProcess/WebStorage/StorageNamespaceIdentifier.h:

Canonical link: https://commits.webkit.org/284708@main

c2d7bf5

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Oct 4, 2024
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Oct 4, 2024
@cdumez cdumez marked this pull request as ready for review October 4, 2024 22:32
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 4, 2024
https://bugs.webkit.org/show_bug.cgi?id=280904

Reviewed by Darin Adler.

* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::clearStorageForWebPage):
(WebKit::NetworkStorageManager::cloneSessionStorageForWebPage):
* Source/WebKit/NetworkProcess/storage/StorageAreaBase.cpp:
(WebKit::StorageAreaBase::dispatchEvents const):
* Source/WebKit/Shared/WTFArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::dispatchMessage):
* Source/WebKit/WebProcess/WebPage/WebPageInlines.h:
(WebKit::WebPage::sessionStorageNamespaceIdentifier const):
* Source/WebKit/WebProcess/WebStorage/StorageAreaImplIdentifier.h:
* Source/WebKit/WebProcess/WebStorage/StorageAreaMapIdentifier.h:
* Source/WebKit/WebProcess/WebStorage/StorageNamespaceIdentifier.h:

Canonical link: https://commits.webkit.org/284708@main
@webkit-commit-queue webkit-commit-queue force-pushed the 280904_StorageArea_ObjectIdentifier branch from c2d7bf5 to 1de9b8f Compare October 4, 2024 22:38
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 284708@main (1de9b8f): https://commits.webkit.org/284708@main

Reviewed commits have been landed. Closing PR #34710 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1de9b8f into WebKit:main Oct 4, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants