Regression(284012@main) Crash under DNSResolveQueueCFNet::performDNSLookup()#34783
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 7, 2024
Merged
Conversation
cdumez
added
the
WebCore Misc.
Collaborator
|
EWS run on current version of this PR (hash 7b149e6) Details |
cdumez
added
the
unsafe-merge-queue
…ookup() https://bugs.webkit.org/show_bug.cgi?id=280987 rdar://137067072 Reviewed by Per Arne Vollan. 284012@main introduced a timeout timer for DNS resolution in DNSResolveQueueCFNet::performDNSLookup(). When the timer would fire, it would cancel the DNS resolution by calling `nw_resolver_cancel()` and THEN call the DNS resolution completion handler. The issue is that the timer itself is owned by the block passed to nw_resolver_set_update_handler(). When calling `nw_resolver_cancel()`, this block would get destroyed, which in turns would destroy the timeout timer and thus its lambda. Then, the timer lambda would try to call the completion handler after it's already been deallocated. * Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp: (WebCore::DNSResolveQueueCFNet::performDNSLookup): Canonical link: https://commits.webkit.org/284776@main
webkit-commit-queue
force-pushed
the
280987_DNSResolveQueueCFNet_crash
branch
from
7b149e6 to
1255032
Compare
Collaborator
|
Committed 284776@main (1255032): https://commits.webkit.org/284776@main Reviewed commits have been landed. Closing PR #34783 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1255032
7b149e6
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 vision-wk2🧪 mac-intel-wk2🛠 mac-safer-cpp🛠 tv-sim🛠 watch