Skip to content

Conversation

@squelart
Copy link
Contributor

@squelart squelart commented Oct 7, 2024

58d02b4

GPUCanvasContextCocoa::getConfiguration()
https://bugs.webkit.org/show_bug.cgi?id=281015
rdar://problem/137461371

Reviewed by Mike Wyrzykowski.

This new function returns the *current* configuration.
In particular, its toneMapping.mode can be forced to "standard"
when HDR is not supported (e.g., on some platforms, or when the
feature flag is turned off.)

* Source/WebCore/Modules/WebGPU/GPUCanvasConfiguration.idl:
* Source/WebCore/Modules/WebGPU/GPUCanvasToneMapping.idl:
* Source/WebCore/Modules/WebGPU/GPUDevice.idl:
* Source/WebCore/html/canvas/GPUCanvasContext.h:
* Source/WebCore/html/canvas/GPUCanvasContext.idl:
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.h:
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm:
(WebCore::GPUCanvasContextCocoa::getConfiguration const):

Canonical link: https://commits.webkit.org/284814@main

aa49b2c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@squelart squelart requested review from cdumez and rniwa as code owners October 7, 2024 23:32
@squelart squelart self-assigned this Oct 7, 2024
@squelart squelart added the WebGPU For bugs in WebGPU label Oct 7, 2024
@squelart squelart added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Oct 8, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Oct 8, 2024
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #34859.

https://bugs.webkit.org/show_bug.cgi?id=281015
rdar://problem/137461371

Reviewed by Mike Wyrzykowski.

This new function returns the *current* configuration.
In particular, its toneMapping.mode can be forced to "standard"
when HDR is not supported (e.g., on some platforms, or when the
feature flag is turned off.)

* Source/WebCore/Modules/WebGPU/GPUCanvasConfiguration.idl:
* Source/WebCore/Modules/WebGPU/GPUCanvasToneMapping.idl:
* Source/WebCore/Modules/WebGPU/GPUDevice.idl:
* Source/WebCore/html/canvas/GPUCanvasContext.h:
* Source/WebCore/html/canvas/GPUCanvasContext.idl:
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.h:
* Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm:
(WebCore::GPUCanvasContextCocoa::getConfiguration const):

Canonical link: https://commits.webkit.org/284814@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GPUCanvasContext-getConfiguration branch from aa49b2c to 58d02b4 Compare October 8, 2024 07:04
@webkit-commit-queue
Copy link
Collaborator

Committed 284814@main (58d02b4): https://commits.webkit.org/284814@main

Reviewed commits have been landed. Closing PR #34807 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 58d02b4 into WebKit:main Oct 8, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants