Drop IsDeprecatedWeakRefSmartPointerException from SQLiteStorageArea & StorageAreaBase by cdumez · Pull Request #35116 · WebKit/WebKit

cdumez · 2024-10-13T06:08:36Z

`f1f97ea`

Drop IsDeprecatedWeakRefSmartPointerException from SQLiteStorageArea & StorageAreaBase
https://bugs.webkit.org/show_bug.cgi?id=281393

Reviewed by Darin Adler.

* Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp:
(WebKit::LocalStorageManager::hasDataInMemory const):
(WebKit::LocalStorageManager::clearDataInMemory):
(WebKit::LocalStorageManager::clearDataOnDisk):
(WebKit::LocalStorageManager::close):
(WebKit::LocalStorageManager::handleLowMemoryWarning):
(WebKit::LocalStorageManager::syncLocalStorage):
(WebKit::LocalStorageManager::connectionClosedForLocalStorageArea):
(WebKit::LocalStorageManager::connectionClosedForTransientStorageArea):
(WebKit::LocalStorageManager::connectToLocalStorageArea):
(WebKit::LocalStorageManager::protectedLocalStorageArea const):
(WebKit::LocalStorageManager::connectToTransientLocalStorageArea):
* Source/WebKit/NetworkProcess/storage/LocalStorageManager.h:
* Source/WebKit/NetworkProcess/storage/MemoryStorageArea.cpp:
(WebKit::MemoryStorageArea::create):
(WebKit::MemoryStorageArea::clone const):
* Source/WebKit/NetworkProcess/storage/MemoryStorageArea.h:
* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp:
(WebKit::SQLiteStorageArea::create):
* Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.h:
* Source/WebKit/NetworkProcess/storage/SessionStorageManager.cpp:
(WebKit::SessionStorageManager::clearData):
(WebKit::SessionStorageManager::connectionClosed):
(WebKit::SessionStorageManager::addStorageArea):
(WebKit::SessionStorageManager::connectToSessionStorageArea):
(WebKit::SessionStorageManager::cancelConnectToSessionStorageArea):
(WebKit::SessionStorageManager::disconnectFromStorageArea):
(WebKit::SessionStorageManager::cloneStorageArea):
* Source/WebKit/NetworkProcess/storage/SessionStorageManager.h:
* Source/WebKit/NetworkProcess/storage/StorageAreaBase.cpp:
(WebKit::StorageAreaBase::hasListeners const): Deleted.
* Source/WebKit/NetworkProcess/storage/StorageAreaBase.h:
(WebKit::StorageAreaBase::hasListeners const):

Canonical link: https://commits.webkit.org/285106@main

9845132

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-10-13T06:09:19Z

EWS run on previous version of this PR (hash 5a15089)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	🛠 gtk
	🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2024-10-13T08:26:28Z

Safer C++ Build #1509

❌ Found 8 new failures. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2024-10-13T18:53:33Z

EWS run on previous version of this PR (hash 7d2a0c9)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

darinadler · 2024-10-13T23:16:25Z

Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp

To match the other local variable names, this would just be transientStorage.

darinadler · 2024-10-13T23:16:30Z

Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp

To match the other local variable names, this would just be transientStorage. Shorter is likely better, but also more consistent would be nicer. Not really important either way. If I was writhing the code, in a class named "storage manager" I’d use the word "area" rather than "storage", since "storage" is implied by the class.

darinadler · 2024-10-13T23:19:21Z

Source/WebKit/NetworkProcess/storage/StorageAreaBase.cpp

Shouldn't leave an extra blank line.

Source/WebKit/NetworkProcess/storage/MemoryStorageArea.h

webkit-early-warning-system · 2024-10-14T00:38:19Z

EWS run on current version of this PR (hash 9845132)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt		✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

…& StorageAreaBase https://bugs.webkit.org/show_bug.cgi?id=281393 Reviewed by Darin Adler. * Source/WebKit/NetworkProcess/storage/LocalStorageManager.cpp: (WebKit::LocalStorageManager::hasDataInMemory const): (WebKit::LocalStorageManager::clearDataInMemory): (WebKit::LocalStorageManager::clearDataOnDisk): (WebKit::LocalStorageManager::close): (WebKit::LocalStorageManager::handleLowMemoryWarning): (WebKit::LocalStorageManager::syncLocalStorage): (WebKit::LocalStorageManager::connectionClosedForLocalStorageArea): (WebKit::LocalStorageManager::connectionClosedForTransientStorageArea): (WebKit::LocalStorageManager::connectToLocalStorageArea): (WebKit::LocalStorageManager::protectedLocalStorageArea const): (WebKit::LocalStorageManager::connectToTransientLocalStorageArea): * Source/WebKit/NetworkProcess/storage/LocalStorageManager.h: * Source/WebKit/NetworkProcess/storage/MemoryStorageArea.cpp: (WebKit::MemoryStorageArea::create): (WebKit::MemoryStorageArea::clone const): * Source/WebKit/NetworkProcess/storage/MemoryStorageArea.h: * Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp: (WebKit::SQLiteStorageArea::create): * Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.h: * Source/WebKit/NetworkProcess/storage/SessionStorageManager.cpp: (WebKit::SessionStorageManager::clearData): (WebKit::SessionStorageManager::connectionClosed): (WebKit::SessionStorageManager::addStorageArea): (WebKit::SessionStorageManager::connectToSessionStorageArea): (WebKit::SessionStorageManager::cancelConnectToSessionStorageArea): (WebKit::SessionStorageManager::disconnectFromStorageArea): (WebKit::SessionStorageManager::cloneStorageArea): * Source/WebKit/NetworkProcess/storage/SessionStorageManager.h: * Source/WebKit/NetworkProcess/storage/StorageAreaBase.cpp: (WebKit::StorageAreaBase::hasListeners const): Deleted. * Source/WebKit/NetworkProcess/storage/StorageAreaBase.h: (WebKit::StorageAreaBase::hasListeners const): Canonical link: https://commits.webkit.org/285106@main

webkit-commit-queue · 2024-10-14T02:11:10Z

Committed 285106@main (f1f97ea): https://commits.webkit.org/285106@main

Reviewed commits have been landed. Closing PR #35116 and removing active labels.

cdumez self-assigned this Oct 13, 2024

cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Oct 13, 2024

cdumez force-pushed the 281393_StorageAreaBase branch from 5a15089 to 7d2a0c9 Compare October 13, 2024 18:53

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2024

cdumez marked this pull request as ready for review October 13, 2024 20:51

cdumez requested review from darinadler, geoffreygaren and rniwa October 13, 2024 20:51

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 13, 2024

darinadler approved these changes Oct 13, 2024

View reviewed changes

cdumez force-pushed the 281393_StorageAreaBase branch from 7d2a0c9 to 9845132 Compare October 14, 2024 00:38

cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2024

webkit-commit-queue force-pushed the 281393_StorageAreaBase branch from 9845132 to f1f97ea Compare October 14, 2024 02:11

webkit-commit-queue merged commit f1f97ea into WebKit:main Oct 14, 2024

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop IsDeprecatedWeakRefSmartPointerException from SQLiteStorageArea & StorageAreaBase#35116

Drop IsDeprecatedWeakRefSmartPointerException from SQLiteStorageArea & StorageAreaBase#35116
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:281393_StorageAreaBase

cdumez commented Oct 13, 2024 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Oct 13, 2024 •

edited

Loading

Uh oh!

webkit-ews-buildbot commented Oct 13, 2024

Uh oh!

webkit-early-warning-system commented Oct 13, 2024 •

edited

Loading

Uh oh!

darinadler Oct 13, 2024

Uh oh!

darinadler Oct 13, 2024

Uh oh!

darinadler Oct 13, 2024

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 14, 2024 •

edited

Loading

Uh oh!

webkit-commit-queue commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

cdumez commented Oct 13, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

f1f97ea

Uh oh!

webkit-early-warning-system commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Oct 13, 2024

Safer C++ Build #1509

Uh oh!

webkit-early-warning-system commented Oct 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darinadler Oct 13, 2024

Choose a reason for hiding this comment

Uh oh!

darinadler Oct 13, 2024

Choose a reason for hiding this comment

Uh oh!

darinadler Oct 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

webkit-early-warning-system commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cdumez commented Oct 13, 2024 •

edited by webkit-early-warning-system

Loading

`f1f97ea`

webkit-early-warning-system commented Oct 13, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 14, 2024 •

edited

Loading