Skip to content

Conversation

@Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Oct 15, 2024

ee0481b

Fix moveTo to not use screenAvailableRect as an origin but as a boundary
https://bugs.webkit.org/show_bug.cgi?id=250800
rdar://104670843

Reviewed by Ryosuke Niwa.

Merge: https://chromium.googlesource.com/chromium/blink/+/f7557ab98c0e2bb380f9bfc6355666434c6e481f

This patch is to fix a bug where we use `screenAvailableRect` as an origin,
which can lead to window being offset based on menu bar height. It changes
`screenAvailableRect` from origin to boundary.

* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::moveTo const):
* LayoutTests/fast/dom/Window/window-resize-and-move-arguments-expected.txt:
* LayoutTests/fast/dom/Window/window-resize-and-move-arguments.html:

Canonical link: https://commits.webkit.org/285205@main

5ed0042

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 self-assigned this Oct 15, 2024
@Ahmad-S792 Ahmad-S792 added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Oct 15, 2024
@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Oct 15, 2024
https://bugs.webkit.org/show_bug.cgi?id=250800
rdar://104670843

Reviewed by Ryosuke Niwa.

Merge: https://chromium.googlesource.com/chromium/blink/+/f7557ab98c0e2bb380f9bfc6355666434c6e481f

This patch is to fix a bug where we use `screenAvailableRect` as an origin,
which can lead to window being offset based on menu bar height. It changes
`screenAvailableRect` from origin to boundary.

* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::moveTo const):
* LayoutTests/fast/dom/Window/window-resize-and-move-arguments-expected.txt:
* LayoutTests/fast/dom/Window/window-resize-and-move-arguments.html:

Canonical link: https://commits.webkit.org/285205@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-moveTo-to-not-use-screenAvailableRect-as-an-origin-but-as-a-boundary branch from 5ed0042 to ee0481b Compare October 15, 2024 17:35
@webkit-commit-queue
Copy link
Collaborator

Committed 285205@main (ee0481b): https://commits.webkit.org/285205@main

Reviewed commits have been landed. Closing PR #35210 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ee0481b into WebKit:main Oct 15, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 15, 2024
@Ahmad-S792 Ahmad-S792 deleted the eng/Fix-moveTo-to-not-use-screenAvailableRect-as-an-origin-but-as-a-boundary branch December 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants