Skip to content

[IsDeprecatedWeakRefSmartPointerException] Remove exception from RemoteRenderingBackendProxy #35269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

[IsDeprecatedWeakRefSmartPointerException] Remove exception from RemoteRenderingBackendProxy #35269

merged 1 commit into from
Oct 16, 2024

Conversation

@RupinMittal
Copy link
Contributor

@RupinMittal RupinMittal commented Oct 16, 2024 •
edited by webkit-early-warning-system
Loading

06d8494

[IsDeprecatedWeakRefSmartPointerException] Remove exception from RemoteRenderingBackendProxy
https://bugs.webkit.org/show_bug.cgi?id=281558
rdar://138016364

Reviewed by Chris Dumez and Geoffrey Garen.

Since RemoteRenderingBackendProxy does not inherit from `CanMakeWeakPtr`,
it does not need IsDeprecatedWeakRefSmartPointerException.

* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

Canonical link: https://commits.webkit.org/285283@main

f090e59

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@RupinMittal RupinMittal self-assigned this Oct 16, 2024
@RupinMittal RupinMittal added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Oct 16, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 16, 2024 •
edited
Loading

EWS run on previous version of this PR (hash cc75797)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
  🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
loading 🛠 🧪 jsc-arm64   🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2
  🛠 tv   🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@RupinMittal RupinMittal force-pushed the eng/IsDeprecatedWeakRefSmartPointerException-Remove-exception-from-RemoteRenderingBackendProxy branch from cc75797 to f090e59 Compare October 16, 2024 05:51
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 16, 2024 •
edited
Loading

EWS run on current version of this PR (hash f090e59)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@RupinMittal RupinMittal marked this pull request as ready for review October 16, 2024 17:34
@RupinMittal RupinMittal requested a review from cdumez as a code owner October 16, 2024 17:34
geoffreygaren
geoffreygaren approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@RupinMittal RupinMittal added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 16, 2024
@RupinMittal
[IsDeprecatedWeakRefSmartPointerException] Remove exception from Remo…
06d8494 
…teRenderingBackendProxy

https://bugs.webkit.org/show_bug.cgi?id=281558
rdar://138016364

Reviewed by Chris Dumez and Geoffrey Garen.

Since RemoteRenderingBackendProxy does not inherit from `CanMakeWeakPtr`,
it does not need IsDeprecatedWeakRefSmartPointerException.

* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

Canonical link: https://commits.webkit.org/285283@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/IsDeprecatedWeakRefSmartPointerException-Remove-exception-from-RemoteRenderingBackendProxy branch from f090e59 to 06d8494 Compare October 16, 2024 18:43
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Oct 16, 2024

Committed 285283@main (06d8494): https://commits.webkit.org/285283@main

Reviewed commits have been landed. Closing PR #35269 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 06d8494 into WebKit:main Oct 16, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez cdumez approved these changes

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@rniwa rniwa Awaiting requested review from rniwa

Assignees

@RupinMittal RupinMittal

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RupinMittal @webkit-early-warning-system @webkit-commit-queue @cdumez @geoffreygaren