[visionOS] Relax criteria for Panoramic images to delegate fullscreen to Quick Look

[yoelhawa]

42e1ee2

[visionOS] Relax criteria for Panoramic images to delegate fullscreen to Quick Look
https://bugs.webkit.org/show_bug.cgi?id=281632
<rdar://136329595>

Reviewed by Said Abou-Hallawa.

On visionOS, delegate element fullscreen to Quick Look for any image
that is wide enough to be a Panoramic image, even if it isn't large
enough. That way, if `srcset` switches the image source to one large
enough to be a Panoramic image after going fullscreen, Quick Look
will already be open to display it.

* Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::ImageDecoderCG::isMaybePanoramic const):
(WebCore::ImageDecoderCG::shouldUseQuickLookForFullscreen const):
(WebCore::ImageDecoderCG::isPanoramic const): Deleted.
* Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:
Loosen the criteria for panorama detection.

Canonical link: https://commits.webkit.org/285388@main

f12527b

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash f1c5e37)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	🛠 ios	✅ 🛠 mac	🛠 wpe	🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	🧪 mac-wk1	🛠 wpe-cairo
	⏳ 🧪 api-ios	🧪 mac-wk2	🛠 gtk
	🛠 vision	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	🛠 vision-sim	🧪 mac-wk2-stress	🧪 api-gtk
	⏳ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2
	🛠 tv	🛠 mac-safer-cpp
	🛠 tv-sim
	🛠 watch
	🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash f12527b)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[shallawa]

If the size of the image is small like { 30 x 10 } and there is no srcset around this image in the page, will opening QuickLook in this case be okay?

Should not we make the decision to use QuickLook at a higher level where more context about the image is known?

[yoelhawa]

Perhaps we can be more refined with the heuristic, but there's little risk to using Quick Look for fullscreen (it now presents an identical visual experience to the user as regular element fullscreen)

[webkit-commit-queue]

Committed 285388@main (42e1ee2): https://commits.webkit.org/285388@main

Reviewed commits have been landed. Closing PR #35329 and removing active labels.