Skip to content

Drop IsDeprecatedWeakRefSmartPointerException from RemoteMediaEngineConfigurationFactory#35410

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rniwa:fix281723-RemoteMediaEngineConfigurationFactory
Oct 18, 2024
Merged

Drop IsDeprecatedWeakRefSmartPointerException from RemoteMediaEngineConfigurationFactory#35410
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
rniwa:fix281723-RemoteMediaEngineConfigurationFactory

Conversation

@rniwa
Copy link
Copy Markdown
Member

@rniwa rniwa commented Oct 18, 2024

2ae484e

Drop IsDeprecatedWeakRefSmartPointerException from RemoteMediaEngineConfigurationFactory
https://bugs.webkit.org/show_bug.cgi?id=281723

Reviewed by Chris Dumez.

* Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp:
(WebKit::RemoteMediaEngineConfigurationFactory::RemoteMediaEngineConfigurationFactory):
* Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.h:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setUseGPUProcessForMedia):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/285411@main

1dda98f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@rniwa rniwa requested a review from cdumez as a code owner October 18, 2024 06:52
@rniwa rniwa self-assigned this Oct 18, 2024
@rniwa rniwa added the WebKit2 Bugs relating to the WebKit2 API layer label Oct 18, 2024
Copy link
Copy Markdown
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 18, 2024
…onfigurationFactory

https://bugs.webkit.org/show_bug.cgi?id=281723

Reviewed by Chris Dumez.

* Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp:
(WebKit::RemoteMediaEngineConfigurationFactory::RemoteMediaEngineConfigurationFactory):
* Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.h:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setUseGPUProcessForMedia):
* Source/WebKit/WebProcess/WebProcess.h:

Canonical link: https://commits.webkit.org/285411@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix281723-RemoteMediaEngineConfigurationFactory branch from 1dda98f to 2ae484e Compare October 18, 2024 15:57
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 285411@main (2ae484e): https://commits.webkit.org/285411@main

Reviewed commits have been landed. Closing PR #35410 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2ae484e into WebKit:main Oct 18, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 18, 2024
@rniwa rniwa deleted the fix281723-RemoteMediaEngineConfigurationFactory branch April 13, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit2 Bugs relating to the WebKit2 API layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants