Skip to content

Conversation

@fujii
Copy link
Contributor

@fujii fujii commented Oct 22, 2024

f0294b5

[TextureMapper] Convert class-level WEBCORE_EXPORT to method-level
https://bugs.webkit.org/show_bug.cgi?id=281899

Reviewed by Carlos Garcia Campos.

check-webkit-style complains inline functions in class-level
WEBCORE_EXPORT. And, WebKit prefers method-level WEBCORE_EXPORT.

* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:

Canonical link: https://commits.webkit.org/285551@main

ac941d0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
⏳ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
⏳ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge ⏳ 🛠 tv 🛠 mac-safer-cpp
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

@fujii fujii self-assigned this Oct 22, 2024
@fujii fujii added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Oct 22, 2024
@fujii fujii added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=281899

Reviewed by Carlos Garcia Campos.

check-webkit-style complains inline functions in class-level
WEBCORE_EXPORT. And, WebKit prefers method-level WEBCORE_EXPORT.

* Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:
* Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:

Canonical link: https://commits.webkit.org/285551@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/TextureMapper-Convert-class-level-WEBCORE_EXPORT-to-method-level branch from ac941d0 to f0294b5 Compare October 22, 2024 10:18
@webkit-commit-queue
Copy link
Collaborator

Committed 285551@main (f0294b5): https://commits.webkit.org/285551@main

Reviewed commits have been landed. Closing PR #35568 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f0294b5 into WebKit:main Oct 22, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 22, 2024
@fujii fujii deleted the eng/TextureMapper-Convert-class-level-WEBCORE_EXPORT-to-method-level branch October 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants