REGRESSION (iOS 18): 5 WPT CSS layout tests are constantly failing (ImageOnlyFailure).#35593
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 23, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash f247958) Details |
…mageOnlyFailure). https://bugs.webkit.org/show_bug.cgi?id=277933 rdar://133651925 Reviewed by Tim Nguyen. Allowing fuzzy tolerance to the following tests. Tests diff by very few pixels (example: maxDifference=0-123; totalPixels=1). I can just observe it when running our test suite. When opening the test file on Safari/Minibrowser I observe no apparent clipping or differences between test/expected. I believe this is being introduced by anti-aliasing during test for some reason and it should not have user impact. * LayoutTests/fast/text/text-underline-position-under.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-content/quotes-025.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-content/quotes-026.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-content/quotes-027.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-fullwidth-004.xht: * LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-fullwidth-005.xht: * LayoutTests/platform/ios/TestExpectations: Canonical link: https://commits.webkit.org/285585@main
webkit-commit-queue
force-pushed
the
eng/REGRESSION-iOS-18-5-WPT-CSS-layout-tests-are-constantly-failing-ImageOnlyFailure-
branch
from
f247958 to
d0deb00
Compare
Collaborator
|
Committed 285585@main (d0deb00): https://commits.webkit.org/285585@main Reviewed commits have been landed. Closing PR #35593 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
vitorroriz
deleted the
eng/REGRESSION-iOS-18-5-WPT-CSS-layout-tests-are-constantly-failing-ImageOnlyFailure-
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
d0deb00
f247958
🧪 mac-AS-debug-wk2🛠 vision-sim