Sometimes, WKTR installation does not succeed in the Simulator#35709
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Oct 25, 2024
Conversation
pvollan
force-pushed
the
eng/Sometimes-WKTR-installation-does-not-succeed-in-the-Simulator
branch
from
99fde22 to
9f0fae5
Compare
pvollan
added
the
Tools / Tests
Collaborator
|
EWS run on previous version of this PR (hash 9f0fae5) Details |
pvollan
force-pushed
the
eng/Sometimes-WKTR-installation-does-not-succeed-in-the-Simulator
branch
from
9f0fae5 to
601d5f6
Compare
Collaborator
|
EWS run on current version of this PR (hash 601d5f6) Details |
pvollan
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=281875 rdar://138351968 Reviewed by Elliott Williams. This is caused by a daemon involved in the installation being suspended. This patch works around this issue by creating a small utility that sends a XPC message to the daemon in order to resume execution. This issue is flaky, so it is hard to confirm the fix is sufficient, but local testing looks good. This patch was previously reviewed in WebKit#35544 and landed in https://commits.webkit.org/285637@main. It is being relanded with a build fix for Debug mode. * Tools/Scripts/webkitpy/xcode/simulated_device.py: (SimulatedDevice.install_app): * Tools/WebKitTestRunner/Configurations/WebKitEligibilityUtil.xcconfig: Added. * Tools/WebKitTestRunner/WebKitEligibilityUtil/main.cpp: Added. (main): * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/285704@main
webkit-commit-queue
force-pushed
the
eng/Sometimes-WKTR-installation-does-not-succeed-in-the-Simulator
branch
from
601d5f6 to
642ca04
Compare
Collaborator
|
Committed 285704@main (642ca04): https://commits.webkit.org/285704@main Reviewed commits have been landed. Closing PR #35709 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
642ca04
601d5f6
🧪 wpe-wk2🧪 api-mac🧪 api-wpe