Skip to content

Nullptr crash under RenderTreeBuilder::Inline::splitInlines while transitioning to fullscreen#35857

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
anttijk:fullscreen-style-sharing-crash
Oct 29, 2024
Merged

Nullptr crash under RenderTreeBuilder::Inline::splitInlines while transitioning to fullscreen#35857
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
anttijk:fullscreen-style-sharing-crash

Conversation

@anttijk
Copy link
Copy Markdown
Contributor

@anttijk anttijk commented Oct 29, 2024

30fb035

Nullptr crash under RenderTreeBuilder::Inline::splitInlines while transitioning to fullscreen
https://bugs.webkit.org/show_bug.cgi?id=282231
rdar://137177522

Reviewed by Alan Baradlay.

* LayoutTests/fast/css/fullscreen-style-sharing-crash-expected.txt: Added.
* LayoutTests/fast/css/fullscreen-style-sharing-crash.html: Added.
* Source/WebCore/style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement const):

We were improperly sharing style between elements that had different top layer status and fullscreen flags.
This led to illegal render tree structure.

Canonical link: https://commits.webkit.org/285832@main

67fa0f9

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ⏳ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ❌ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk self-assigned this Oct 29, 2024
@anttijk anttijk added the CSS Cascading Style Sheets implementation label Oct 29, 2024
@anttijk anttijk force-pushed the fullscreen-style-sharing-crash branch from ea18c9a to 25c05e0 Compare October 29, 2024 11:35
@anttijk anttijk force-pushed the fullscreen-style-sharing-crash branch from 25c05e0 to 67fa0f9 Compare October 29, 2024 11:37
@anttijk anttijk added the merge-queue Applied to send a pull request to merge-queue label Oct 29, 2024
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Oct 29, 2024
@anttijk anttijk added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Oct 29, 2024
…nsitioning to fullscreen

https://bugs.webkit.org/show_bug.cgi?id=282231
rdar://137177522

Reviewed by Alan Baradlay.

* LayoutTests/fast/css/fullscreen-style-sharing-crash-expected.txt: Added.
* LayoutTests/fast/css/fullscreen-style-sharing-crash.html: Added.
* Source/WebCore/style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement const):

We were improperly sharing style between elements that had different top layer status and fullscreen flags.
This led to illegal render tree structure.

Canonical link: https://commits.webkit.org/285832@main
@webkit-commit-queue webkit-commit-queue force-pushed the fullscreen-style-sharing-crash branch from 67fa0f9 to 30fb035 Compare October 29, 2024 14:49
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 285832@main (30fb035): https://commits.webkit.org/285832@main

Reviewed commits have been landed. Closing PR #35857 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 30fb035 into WebKit:main Oct 29, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CSS Cascading Style Sheets implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants