Nullptr crash under RenderTreeBuilder::Inline::splitInlines while transitioning to fullscreen#35857
Merged
webkit-commit-queue merged 1 commit intoOct 29, 2024
Conversation
Collaborator
|
EWS run on previous version of this PR (hash ea18c9a) Details |
ea18c9a to
25c05e0
Compare
Collaborator
|
EWS run on previous version of this PR (hash 25c05e0) Details |
25c05e0 to
67fa0f9
Compare
Collaborator
|
EWS run on current version of this PR (hash 67fa0f9) Details |
alanbaradlay
approved these changes
Oct 29, 2024
…nsitioning to fullscreen https://bugs.webkit.org/show_bug.cgi?id=282231 rdar://137177522 Reviewed by Alan Baradlay. * LayoutTests/fast/css/fullscreen-style-sharing-crash-expected.txt: Added. * LayoutTests/fast/css/fullscreen-style-sharing-crash.html: Added. * Source/WebCore/style/StyleSharingResolver.cpp: (WebCore::Style::SharingResolver::canShareStyleWithElement const): We were improperly sharing style between elements that had different top layer status and fullscreen flags. This led to illegal render tree structure. Canonical link: https://commits.webkit.org/285832@main
67fa0f9 to
30fb035
Compare
Collaborator
|
Committed 285832@main (30fb035): https://commits.webkit.org/285832@main Reviewed commits have been landed. Closing PR #35857 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
30fb035
67fa0f9